From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24519 invoked by alias); 17 Dec 2011 03:08:20 -0000 Received: (qmail 24509 invoked by uid 22791); 17 Dec 2011 03:08:18 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Dec 2011 03:08:06 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Rbkd3-0007kB-C3 from pedro_alves@mentor.com for gdb-patches@sourceware.org; Fri, 16 Dec 2011 19:08:05 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Sat, 17 Dec 2011 03:08:03 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [RFC/WIP PATCH v2 14/12] experiment with "scope" Date: Sat, 17 Dec 2011 08:49:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) References: <20111217025904.22456.50717.stgit@localhost6.localdomain6> In-Reply-To: <20111217025904.22456.50717.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201112170307.56996.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00560.txt.bz2 On Saturday 17 December 2011 02:59:04, Pedro Alves wrote: > The name of this new concept is still up for grabs. Let me repeat a > bit of the discussion on the v1 series on the topic here: > > Tromey wrote: > > Pedro> IPTC sets are a collection of arbitrarily many processes, > > Pedro> threads, and cores. > > > > I wish we had a better name. > > > > The current name seems to gain a letter with every new thread on the > > topic :-) > > That was kind of on purpose. :-) > > The best name I could think of is "scope". If we call these things > scopes, we can also rename the itfocus command to "scope", which can > be abbreviated as "sc". ("s" is already step, obviously). It's spelled > itfocus currently because "focus" was already taken by the TUI. > > It looks like this: > > curinf> scope t3 break -stop i1 main > Breakpoint 2 at 0x40068c: file threads.c, line 35. > curinf> scope i1 > Current inferior is 1. > i1> sc all > Current inferior is 1. > all> > > WDYT? I wrote this patch to try out how it feels to use "scope" for things. Also not in git. -- Pedro Alves --- gdb/infrun.c | 2 +- gdb/itset.c | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index c3e6d0d..89cb51a 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -1647,7 +1647,7 @@ set_schedlock_func (char *args, int from_tty, struct cmd_list_element *c) } /* True if execution commands resume all threads of all processes in - the current focus by default; otherwise, resume only threads of the + the current scope by default; otherwise, resume only threads of the current inferior process. */ int sched_multi = 1; diff --git a/gdb/itset.c b/gdb/itset.c index d65cc37..8ea89aa 100644 --- a/gdb/itset.c +++ b/gdb/itset.c @@ -1521,7 +1521,7 @@ make_cleanup_itset_free (struct itset *itset) static struct itset_elt *parse_neg (char **spec); static struct itset_elt *parse_parens_set (char **spec); static struct itset_elt *parse_itset_one (char **spec); -static struct itset_elt *parse_current_focus (char **spec); +static struct itset_elt *parse_current_scope (char **spec); static int valid_spec_end (char *spec) @@ -1554,7 +1554,7 @@ parse_elem (char **spec) if (elt != NULL) return elt; - elt = parse_current_focus (spec); + elt = parse_current_scope (spec); if (elt != NULL) return elt; @@ -1581,7 +1581,7 @@ parse_neg (char **spec) } static struct itset_elt * -parse_current_focus (char **spec) +parse_current_scope (char **spec) { struct itset_elt_itset *itset_elt; @@ -2026,7 +2026,7 @@ switch_to_itset (struct itset *itset) int inf_count; /* For now, set a current inferior from the first element of the - focus set. */ + scope set. */ inf = iterate_over_itset_inferiors (itset, first_inferior, NULL); if (inf == NULL) { @@ -2073,7 +2073,7 @@ switch_to_itset (struct itset *itset) } static void -itfocus_command (char *spec, int from_tty) +scope_command (char *spec, int from_tty) { struct itset *itset; struct cleanup *old_chain; @@ -2081,11 +2081,11 @@ itfocus_command (char *spec, int from_tty) if (spec == NULL) { if (current_itset) - printf_filtered (_("Focus is `%s' (current inferior is %d)"), + printf_filtered (_("Scope is `%s' (current inferior is %d)"), current_itset->spec, current_inferior ()->num); else - printf_filtered (_("No focus has been set. (current inferior is %d)"), + printf_filtered (_("No scope has been set. (current inferior is %d)"), current_inferior ()->num); printf_filtered ("\n"); return; @@ -2111,7 +2111,7 @@ itfocus_command (char *spec, int from_tty) } if (itset_is_empty (itset)) - warning (_("focus set is empty")); + warning (_("scope set is empty")); discard_cleanups (old_chain); @@ -2120,7 +2120,7 @@ itfocus_command (char *spec, int from_tty) switch_to_itset (itset); - /* Confirm the choice of focus. */ + /* Confirm the choice of scope. */ printf_filtered (_("Current inferior is %d.\n"), current_inferior ()->num); } @@ -2515,7 +2515,7 @@ _initialize_itset (void) current_itset = itset_reference (curinf_itset); - add_com ("itfocus", no_class, itfocus_command, _("\ + add_com ("scope", no_class, scope_command, _("\ Change the set of current inferiors/threads.")); add_com ("defset", no_class, defset_command, _("\