FYI: fixlet in ovsrch.exp (Was: creating the gdb-7.4 branch tomorrow (?))

Tom Tromey
2011-12-08T15:30:09Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Tue, 06 Dec 2011 18:41:32 +0100, Tom Tromey wrote:
>> Here is the series I am checking in.

Jan> There is a regression for 32-bit targets on Fedora 16:
Jan> FAIL: gdb.cp/ovsrch.exp: break A::outer::foo (char*) const if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break 'A::outer::foo (char*) const' if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break A::outer::foo (int) const if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break 'A::outer::foo (int) const' if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break A::B::inner::foo (char*) const if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break 'A::B::inner::foo (char*) const' if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break A::B::inner::foo (int) const if (a == 3)
Jan> FAIL: gdb.cp/ovsrch.exp: break 'A::B::inner::foo (int) const' if (a == 3)

Thanks.

I missed a spot when changing the parameter names in ovsrch.exp, and
didn't notice because I have the 64-bit glibc debuginfo installed, which
provides a minsym named "a".

This patch fixes the problem. I am checking it in.

Tom

2011-12-08 Tom Tromey <tromey@redhat.com>

* gdb.cp/ovsrch.exp (test_class): Correctly use "a_param" in
condition.

diff --git a/gdb/testsuite/gdb.cp/ovsrch.exp b/gdb/testsuite/gdb.cp/ovsrch.exp
index f6ad34b..b75a00c 100644
--- a/gdb/testsuite/gdb.cp/ovsrch.exp
+++ b/gdb/testsuite/gdb.cp/ovsrch.exp
@@ -30,7 +30,7 @@ proc test_class {class} {
}

# Test each overload instance twice: once quoted, once unquoted
- set conditional1 "if (a == 3)"
+ set conditional1 "if (a_param == 3)"
set conditional2 "if (A::outer::func ())"
foreach ovld [array names tests] {
set method "${class}::foo ($ovld) const"