[patch] gcc KFAILs to XFAILs [Re: [commit] testsuite: KFAIL gdb.cp/static-method.exp]

Jan Kratochvil
2011-12-14T18:57:52Z

On Sun, 11 Dec 2011 13:42:13 +0100, Joel Brobecker wrote:
> This is why I would say it's convenient to use KFAIL for GDB bugs only.

I somehow have the same opinion and Tom declined reply, I will check this in
with no reply:

(I have a follow-up fix, some these tests are bogus now.)

Thanka,
Jan

gdb/testsuite/
2011-12-14 Jan Kratochvil <jan.kratochvil@redhat.com>

* gdb.cp/ptype-cv-cp.exp (ptype v_volatile_const_my_int): Replace KFAIL
by XFAIL.
* gdb.cp/static-method.exp (info addr A::func())
(list static-method.cc:xxx::(anonymous namespace)::A::func)
(list 'static-method.cc:xxx::(anonymous namespace)::A::func')
(list 'static-method.cc':'xxx::(anonymous namespace)::A::func')
(list static-method.cc:'xxx::(anonymous namespace)::A::func'): Likewise.
* gdb.cp/temargs.exp (test value of F in k2_m, test type of F in k3_m)
(test value of F in k3_m): Likewise.
* gdb.python/py-type.exp (python print ttype.template_argument(2)):
Likewise.

--- a/gdb/testsuite/gdb.cp/ptype-cv-cp.exp
+++ b/gdb/testsuite/gdb.cp/ptype-cv-cp.exp
@@ -37,5 +37,5 @@ gdb_test "whatis v_const_volatile_my_int" "type = const_volatile_my_int"
gdb_test "ptype v_const_volatile_my_int" "type = const volatile int"

gdb_test "whatis v_volatile_const_my_int" "type = volatile_const_my_int"
-setup_kfail "gcc/45997" *-*-*
+setup_xfail "gcc/45997" "*-*-*"
gdb_test "ptype v_volatile_const_my_int" "type = const volatile int"
--- a/gdb/testsuite/gdb.cp/static-method.exp
+++ b/gdb/testsuite/gdb.cp/static-method.exp
@@ -60,7 +60,8 @@ gdb_test_multiple $test $test {
pass $test
}
-re "Symbol \"A::func\\(\\)\" is a function at address .*\r\n$gdb_prompt $" {
- kfail gcc/45682 $test
+ setup_xfail gcc/45682 "*-*-*"
+ fail $test
set have_gcc_45682_fixed 0
}
}
@@ -87,22 +88,22 @@ foreach test $methods {
# with the filename pre-pended.
if {[string compare $test "xxx::${ans}::A::func"] == 0
&& !$have_gcc_45682_fixed} {
- setup_kfail gcc/45682 "*-*-*"
+ setup_xfail gcc/45682 "*-*-*"
}
gdb_test "list ${srcfile}:$test" $result
if {[string compare $test "xxx::${ans}::A::func"] == 0
&& !$have_gcc_45682_fixed} {
- setup_kfail gcc/45682 "*-*-*"
+ setup_xfail gcc/45682 "*-*-*"
}
gdb_test "list '${srcfile}:$test'" $result
if {[string compare $test "xxx::${ans}::A::func"] == 0
&& !$have_gcc_45682_fixed} {
- setup_kfail gcc/45682 "*-*-*"
+ setup_xfail gcc/45682 "*-*-*"
}
gdb_test "list '${srcfile}':'$test'" $result
if {[string compare $test "xxx::${ans}::A::func"] == 0
&& !$have_gcc_45682_fixed} {
- setup_kfail gcc/45682 "*-*-*"
+ setup_xfail gcc/45682 "*-*-*"
}
gdb_test "list ${srcfile}:'$test'" $result

--- a/gdb/testsuite/gdb.cp/temargs.exp
+++ b/gdb/testsuite/gdb.cp/temargs.exp
@@ -176,7 +176,7 @@ if $have_older_template_gcc { setup_xfail "*-*-*" }
gdb_test "ptype F" "type = void \\\(S::\\\*\\\)\\\(S \\\* const\\\)" \
"test type of F in k2_m"

-setup_kfail gcc/49366 "*-*-*"
+setup_xfail gcc/49366 "*-*-*"
gdb_test "print F" "&S::somefunc" "test value of F in k2_m"

#
@@ -189,10 +189,10 @@ gdb_test "print F" "&S::somefunc" "test value of F in k2_m"
gdb_continue_to_breakpoint "continue to sixth breakpoint for temargs"

if $have_older_template_gcc { setup_xfail "*-*-*"
-} else { setup_kfail gcc/49546 "*-*-*" }
+} else { setup_xfail gcc/49546 "*-*-*" }
gdb_test "ptype F" {type = void \(\*\)\(int\)} "test type of F in k3_m"

if $have_older_template_gcc { setup_xfail "*-*-*"
-} else { setup_kfail gcc/49546 "*-*-*" }
+} else { setup_xfail gcc/49546 "*-*-*" }
gdb_test "print F" { = \(void \(\*\)\(int\)\) 0x[0-9a-f]+ <S3::m\(int\)>} \
"test value of F in k3_m"
--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -193,7 +193,7 @@ proc test_template {} {
gdb_test "python print isinstance(ttype.template_argument(1), gdb.Value)" \
"True"

- setup_kfail "gcc/41736" *-*-*
+ setup_xfail "gcc/41736" *-*-*
gdb_test "python print ttype.template_argument(2)" "&C::c"
}