From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24637 invoked by alias); 14 Dec 2011 18:57:52 -0000 Received: (qmail 24622 invoked by uid 22791); 14 Dec 2011 18:57:50 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Dec 2011 18:57:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBEIv78K013830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 Dec 2011 13:57:08 -0500 Received: from host2.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBEIurBR018341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 14 Dec 2011 13:56:58 -0500 Date: Wed, 14 Dec 2011 19:02:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: [patch] gcc KFAILs to XFAILs [Re: [commit] testsuite: KFAIL gdb.cp/static-method.exp] Message-ID: <20111214185650.GA8485@host2.jankratochvil.net> References: <20111205081911.GG28486@adacore.com> <20111209171630.GA30059@host2.jankratochvil.net> <20111209171937.GA30594@host2.jankratochvil.net> <20111209215319.GA5132@host2.jankratochvil.net> <20111210160145.GA7261@host2.jankratochvil.net> <20111211024742.GN21915@adacore.com> <20111211092552.GA14574@host2.jankratochvil.net> <20111211124213.GO21915@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111211124213.GO21915@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00463.txt.bz2 On Sun, 11 Dec 2011 13:42:13 +0100, Joel Brobecker wrote: > This is why I would say it's convenient to use KFAIL for GDB bugs only. I somehow have the same opinion and Tom declined reply, I will check this in with no reply: (I have a follow-up fix, some these tests are bogus now.) Thanka, Jan gdb/testsuite/ 2011-12-14 Jan Kratochvil * gdb.cp/ptype-cv-cp.exp (ptype v_volatile_const_my_int): Replace KFAIL by XFAIL. * gdb.cp/static-method.exp (info addr A::func()) (list static-method.cc:xxx::(anonymous namespace)::A::func) (list 'static-method.cc:xxx::(anonymous namespace)::A::func') (list 'static-method.cc':'xxx::(anonymous namespace)::A::func') (list static-method.cc:'xxx::(anonymous namespace)::A::func'): Likewise. * gdb.cp/temargs.exp (test value of F in k2_m, test type of F in k3_m) (test value of F in k3_m): Likewise. * gdb.python/py-type.exp (python print ttype.template_argument(2)): Likewise. --- a/gdb/testsuite/gdb.cp/ptype-cv-cp.exp +++ b/gdb/testsuite/gdb.cp/ptype-cv-cp.exp @@ -37,5 +37,5 @@ gdb_test "whatis v_const_volatile_my_int" "type = const_volatile_my_int" gdb_test "ptype v_const_volatile_my_int" "type = const volatile int" gdb_test "whatis v_volatile_const_my_int" "type = volatile_const_my_int" -setup_kfail "gcc/45997" *-*-* +setup_xfail "gcc/45997" "*-*-*" gdb_test "ptype v_volatile_const_my_int" "type = const volatile int" --- a/gdb/testsuite/gdb.cp/static-method.exp +++ b/gdb/testsuite/gdb.cp/static-method.exp @@ -60,7 +60,8 @@ gdb_test_multiple $test $test { pass $test } -re "Symbol \"A::func\\(\\)\" is a function at address .*\r\n$gdb_prompt $" { - kfail gcc/45682 $test + setup_xfail gcc/45682 "*-*-*" + fail $test set have_gcc_45682_fixed 0 } } @@ -87,22 +88,22 @@ foreach test $methods { # with the filename pre-pended. if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list ${srcfile}:$test" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list '${srcfile}:$test'" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list '${srcfile}':'$test'" $result if {[string compare $test "xxx::${ans}::A::func"] == 0 && !$have_gcc_45682_fixed} { - setup_kfail gcc/45682 "*-*-*" + setup_xfail gcc/45682 "*-*-*" } gdb_test "list ${srcfile}:'$test'" $result --- a/gdb/testsuite/gdb.cp/temargs.exp +++ b/gdb/testsuite/gdb.cp/temargs.exp @@ -176,7 +176,7 @@ if $have_older_template_gcc { setup_xfail "*-*-*" } gdb_test "ptype F" "type = void \\\(S::\\\*\\\)\\\(S \\\* const\\\)" \ "test type of F in k2_m" -setup_kfail gcc/49366 "*-*-*" +setup_xfail gcc/49366 "*-*-*" gdb_test "print F" "&S::somefunc" "test value of F in k2_m" # @@ -189,10 +189,10 @@ gdb_test "print F" "&S::somefunc" "test value of F in k2_m" gdb_continue_to_breakpoint "continue to sixth breakpoint for temargs" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_kfail gcc/49546 "*-*-*" } +} else { setup_xfail gcc/49546 "*-*-*" } gdb_test "ptype F" {type = void \(\*\)\(int\)} "test type of F in k3_m" if $have_older_template_gcc { setup_xfail "*-*-*" -} else { setup_kfail gcc/49546 "*-*-*" } +} else { setup_xfail gcc/49546 "*-*-*" } gdb_test "print F" { = \(void \(\*\)\(int\)\) 0x[0-9a-f]+ } \ "test value of F in k3_m" --- a/gdb/testsuite/gdb.python/py-type.exp +++ b/gdb/testsuite/gdb.python/py-type.exp @@ -193,7 +193,7 @@ proc test_template {} { gdb_test "python print isinstance(ttype.template_argument(1), gdb.Value)" \ "True" - setup_kfail "gcc/41736" *-*-* + setup_xfail "gcc/41736" *-*-* gdb_test "python print ttype.template_argument(2)" "&C::c" }