From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86092-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14288 invoked by alias); 13 Dec 2011 16:33:14 -0000
Received: (qmail 14277 invoked by uid 22791); 13 Dec 2011 16:33:12 -0000
X-SWARE-Spam-Status: No, hits=-3.2 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Dec 2011 16:32:58 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id pBDGWnpq018543;	Tue, 13 Dec 2011 17:32:49 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id pBDGWlss005431;	Tue, 13 Dec 2011 17:32:47 +0100 (CET)
Date: Tue, 13 Dec 2011 16:47:00 -0000
Message-Id: <201112131632.pBDGWlss005431@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
CC: mark.kettenis@xs4all.nl, andrew.smirnov@gmail.com,        gdb-patches@sourceware.org, andrew.smirnov@gmail.com
In-reply-to: <E1RaNXy-0000mg-1J@fencepost.gnu.org> (message from Eli Zaretskii	on Tue, 13 Dec 2011 03:17:10 -0500)
Subject: Re: [PATCH 036/238] [index] i386-tdep.c: -Wshadow fix
References: <1323747545-29987-1-git-send-email-andrew.smirnov@gmail.com> <1323747545-29987-2-git-send-email-andrew.smirnov@gmail.com> <201112130717.pBD7Hcdp009062@glazunov.sibelius.xs4all.nl> <E1RaNXy-0000mg-1J@fencepost.gnu.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00411.txt.bz2

> Date: Tue, 13 Dec 2011 03:17:10 -0500
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Tue, 13 Dec 2011 08:17:38 +0100 (CET)
> > From: Mark Kettenis <mark.kettenis@xs4all.nl>
> > CC: gdb-patches@sourceware.org, andrew.smirnov@gmail.com
> > 
> > > From: Andrey Smirnov <andrew.smirnov@gmail.com>
> > > Date: Mon, 12 Dec 2011 19:38:39 -0800
> > > 
> > > To ChangeLog:
> > > 	* i386-tdep.c (i386_record_lea_modrm_addr): Rename `index' to
> > > 	`idx'(-Wshadow).
> > > ---
> > >  gdb/i386-tdep.c |    8 ++++----
> > >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > My position on this is unchanged.  I think 'index' is a perfectly good
> > variable name
> 
> And `idx' is its extremely popular synonym.
> 
> How much of personal preferences should area maintainers force on
> contributors, just because they can?

I don't think we have concensus on -Wshadow.  One of the compromises
that has been talked about is to only enable -Wshadow with new
versions on GCC that don't issue warnings for shadowing symbols in
system headers.  That would make the changes in this class unnecessary
and therefore I think they should not be applied.