From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86090-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7994 invoked by alias); 13 Dec 2011 16:21:14 -0000
Received: (qmail 7975 invoked by uid 22791); 13 Dec 2011 16:21:12 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Dec 2011 16:20:59 +0000
Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com)	by relay1.mentorg.com with esmtp 	id 1RaV60-00063Q-83 from pedro_alves@mentor.com ; Tue, 13 Dec 2011 08:20:48 -0800
Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830);	 Tue, 13 Dec 2011 16:20:36 +0000
From: Pedro Alves <pedro@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode
Date: Tue, 13 Dec 2011 16:26:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; )
Cc: gdb-patches@sourceware.org
References: <201112051601.59664.pedro@codesourcery.com> <201112091630.20916.pedro@codesourcery.com> <83iplpmuht.fsf@gnu.org>
In-Reply-To: <83iplpmuht.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201112131620.28214.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00409.txt.bz2

On Friday 09 December 2011 19:10:22, Eli Zaretskii wrote:

> My extra pair of eyes spotted this:
> 
> > --- a/gdb/go32-nat.c
> > +++ b/gdb/go32-nat.c
> > @@ -801,6 +801,28 @@ go32_get_dr6 (void)
> >    return STATUS;
> >  }
> >  
> > +/* Get the value of the DR6 debug status register from the inferior.
> > +   Here we just return the value stored in D_REGS, as we've got it
> > +   from the last go32_wait call.  */
> > +static unsigned long
> > +go32_get_dr7 (void)
> > +{
> > +  return CONTROL;
> > +}
> 
> The comment says DR6, but the function uses dr7.  I think the comment
> is wrong.

Indeed.  I copied the comment from go32_get_dr6, and forgot to adjust.
Fixed now.

> No other comments.  Thanks.

Thanks a lot.

-- 
Pedro Alves