From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30234 invoked by alias); 12 Dec 2011 20:14:19 -0000 Received: (qmail 30208 invoked by uid 22791); 12 Dec 2011 20:14:14 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Dec 2011 20:13:58 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RaCG4-00070e-7b from pedro_alves@mentor.com ; Mon, 12 Dec 2011 12:13:56 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 12 Dec 2011 20:13:54 +0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Date: Mon, 12 Dec 2011 20:30:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) Cc: Tristan Gingold , gdb-patches@sourceware.org References: <201112051601.59664.pedro@codesourcery.com> <20111212172238.GA7737@host2.jankratochvil.net> <20111212183734.GA24356@host2.jankratochvil.net> In-Reply-To: <20111212183734.GA24356@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201112122013.51990.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00353.txt.bz2 On Monday 12 December 2011 18:37:34, Jan Kratochvil wrote: > On Mon, 12 Dec 2011 18:22:38 +0100, Jan Kratochvil wrote: > > I will yet update the testcase to support gdbserver. > > Here you are. > > I have deleted now from: > http://sourceware.org/gdb/wiki/TestingGDB#Native_Board_File > # Can't do hardware watchpoints, in general. > set_board_info gdb,no_hardware_watchpoints 1 > > as all the new tests PASS for me on > {x86_64,x86_64-m32,i686}-fedora16-linux-gnu. Yeah. Maybe we should still have something like if { istarget [ia64*-*-*] || .... } { set_board_info gdb,no_hardware_watchpoints 1 } somewhere gdbserver specific. Some ports, like ia64 gdbserver don't support watchpoints. I think you can test a native gdbserver with this board on ia64-linux, but this isn't really native board specific --- a cross test should find watchpoints support disabled too. Maybe in gdbserver-support.exp? WDYT? > + > +load_lib gdbserver-support.exp > + > +if {[skip_hw_watchpoint_access_tests] > + || (![istarget "i?86-*-linux*"] && ![istarget "x86_64-*-linux*"]) > + || ([is_remote target] && [skip_gdbserver_tests])} { > + return 0 > +} > + > +if [is_remote target] { > + gdbserver_start_extended > +} Hmm, I'm not sure if this is really a good idea to spread gdbserver_start_extended around like this. I think it would be better to skip the test if testing against plain "target remote". I mean, you may be remote testing against qemu, for example. Having the test spawn GDBserver and actually run would be misleading. Once we have a board that tests the whole testsuite with extended-remote working, then we'll clearly want the present board to skip tests it doesn't support. (the gdb.server/ tests being the exception.) WDYT? -- Pedro Alves