From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10346 invoked by alias); 12 Dec 2011 12:53:16 -0000 Received: (qmail 10337 invoked by uid 22791); 12 Dec 2011 12:53:15 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Dec 2011 12:52:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBCCqRcN025654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Dec 2011 07:52:27 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBCCqMXu001369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 12 Dec 2011 07:52:25 -0500 Date: Mon, 12 Dec 2011 14:49:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tristan Gingold , gdb-patches@sourceware.org, Yao Qi , Doug Evans Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Message-ID: <20111212125221.GA11453@host2.jankratochvil.net> References: <201112051601.59664.pedro@codesourcery.com> <201112091630.20916.pedro@codesourcery.com> <20111211203257.GA21456@host2.jankratochvil.net> <201112121120.31827.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201112121120.31827.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00347.txt.bz2 On Mon, 12 Dec 2011 12:20:31 +0100, Pedro Alves wrote: > " gdbserver already has a per-process structure for the debug registers, > yet, your implementation is different, which makes it gratuitously harder > to share and move code between the gdb and gdbserver implementations. " While I agree that current FSF GDB state is what it is and I have to new gdb patch the same as the checked-in gdbserver patch it was chronologically the opposite way as I stated in: http://sourceware.org/ml/gdb-patches/2011-01/msg00561.html The Doug's gdbserver patch was posted 18 months after the gdb patch of mine being ignored. > " gdbserver gets away without the iteration over all threads setting the > debug registers synchronously, which merged to native gdb, I think > could get rid of some of the churn in your patches, I think, in addition > to fixing watchpoints in non-stop mode (PR10729). " > > The latter is what my patch now brings to gdb. In my mind, I was even > helping get those patches closer to being mainlined... Therefore: * I will rebase the 2007 patch on this 2011 non-stop patch of yours. * I will rename structures of the 2007 patch to the 2009 gdbserver one. * Depending on how feasible it will be I will then unify the structures into gdb/common/ as nobody else is working on this part now. I hope this plan is OK to get the 2007 patch checked in. I do not understand why to deal with watchpoints as they still do not work even for GDB-on-GDB debugging as they stop working already during the grand-inferior fork. Moreover the same happens with any desktop apps. Regards, Jan