From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19159 invoked by alias); 11 Dec 2011 20:33:37 -0000 Received: (qmail 19150 invoked by uid 22791); 11 Dec 2011 20:33:36 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 11 Dec 2011 20:33:21 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBBKX4dh015610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 Dec 2011 15:33:04 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pBBKWwml015464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 11 Dec 2011 15:33:01 -0500 Date: Sun, 11 Dec 2011 23:39:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tristan Gingold , gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH] PR threads/10729: x86 hw watchpoints and non-stop mode Message-ID: <20111211203257.GA21456@host2.jankratochvil.net> References: <201112051601.59664.pedro@codesourcery.com> <20111205202513.GA26929@host2.jankratochvil.net> <201112091630.20916.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201112091630.20916.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00336.txt.bz2 On Fri, 09 Dec 2011 17:30:20 +0100, Pedro Alves wrote: > On Monday 05 December 2011 20:25:13, Jan Kratochvil wrote: > > The patchset > > [patch 0/4] hw watchpoints across fork() + multi-inf > > > > which I am rebasing now on top of HEAD which already reimplements its part by > > commit 96fd921972966166fda0eb300bfa4e5479f3b31f > > Author: Pedro Alves > > Date: Fri Jul 22 16:58:30 2011 +0000 > > http://sourceware.org/ml/gdb-patches/2011-07/msg00586.html > > You mean you were already pulling in this non-stop change from > gdbserver? :-( I did not test non-stop but the patch reimplements the amd64_linux_dr removal contained in the patchset started in 2007: http://sourceware.org/ml/gdb-patches/2010-12/msg00041.html Last time you stopped that patchset due to referenced merging with gdbserver http://sourceware.org/ml/gdb-patches/2010-12/msg00348.html which AFAIK Yao Qi was working on but which has not yet happened, so not sure how more years it cannot get merged. It was probably my wrong assumption for the last year the i386-nat.c merging with gdbserver was being worked on while in fact you only mentioned it would be good to do. > --- a/gdb/mi/mi-main.c > +++ b/gdb/mi/mi-main.c > @@ -1743,12 +1743,11 @@ mi_cmd_list_target_features (char *command, char **argv, int argc) > struct cleanup *cleanup = NULL; > struct ui_out *uiout = current_uiout; > > - cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features"); > + cleanup = make_cleanup_ui_out_list_begin_end (uiout, "features"); > if (target_can_async_p ()) > ui_out_field_string (uiout, NULL, "async"); > if (target_can_execute_reverse) > ui_out_field_string (uiout, NULL, "reverse"); > - > do_cleanups (cleanup); > return; > } Unrelated whitespace cleanup only. Not present in the ChangeLog. Regards, Jan