From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5906 invoked by alias); 6 Dec 2011 18:00:01 -0000 Received: (qmail 5882 invoked by uid 22791); 6 Dec 2011 17:59:58 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Dec 2011 17:59:44 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RXzIt-0000e7-V7 from pedro_alves@mentor.com ; Tue, 06 Dec 2011 09:59:44 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 6 Dec 2011 17:59:41 +0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [PATCH 034/238] [misc.] Fix -Wshadow warnings. Date: Tue, 06 Dec 2011 18:25:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) Cc: Andrey Smirnov , gdb-patches@sourceware.org References: <4ECC3FD2.1000309@earthlink.net> <20111205132646.GA3430@adacore.com> In-Reply-To: <20111205132646.GA3430@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201112061759.39946.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00184.txt.bz2 On Monday 05 December 2011 13:26:46, Joel Brobecker wrote: > > > Looks OK to me. But Pedro might comment on the new variable name > > > (sal->sal2). > [...] > > Initially it was sal->las which probably isn't better, so I'll wait > > for some consensus to arise on this patch too. > > FWIW, I'm OK with sal2. I also agree with stan that it's best to > avoid `las' (cute, though :-)) sal2 is fine with me too. There might actually be a bug here, that I still haven't managed to investigate: http://sourceware.org/ml/gdb-patches/2011-03/msg00066.html (but don't let this block your patch.) Michael wanted sal2 too, so sal2 it is. Curiously, we have very few instances of struct symtab_and_line that aren't called "sal" or don't have "sal" in their name: $ grep "struct symtab_and_line[ \t]\+[A-Za-z_]\+;" * -rn | grep -v sal linespec.c:1910: struct symtab_and_line val; linespec.c:2000: struct symtab_and_line val; mi/mi-cmd-file.c:36: struct symtab_and_line st; symtab.c:1923: struct symtab_and_line val; But they're all close enough. Interestingly, sal2 is the first. :-) $ grep sal2 * -rn *empty* Sals are funny creatures. -- Pedro Alves