From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7044 invoked by alias); 5 Dec 2011 14:18:08 -0000 Received: (qmail 7032 invoked by uid 22791); 5 Dec 2011 14:18:07 -0000 X-SWARE-Spam-Status: Yes, hits=5.5 required=5.0 tests=AWL,BAYES_00,BOTNET,FROM_12LTRDOM,RCVD_IN_BRBL_LASTEXT,RDNS_DYNAMIC,TO_NO_BRKTS_DYNIP X-Spam-Check-By: sourceware.org Received: from bl21-173-103.dsl.telepac.pt (HELO localhost6.localdomain6) (2.82.173.103) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 14:17:54 +0000 Received: from localhost6.localdomain6 (localhost.localdomain [127.0.0.1]) by localhost6.localdomain6 (8.14.4/8.14.4/Debian-2ubuntu1) with ESMTP id pB5EHkJ1031371 for ; Mon, 5 Dec 2011 14:17:47 GMT Subject: [PATCH] Remove obsolete hardware watchpoint FIXMEs. To: gdb-patches@sourceware.org From: Pedro Alves Date: Mon, 05 Dec 2011 14:52:00 -0000 Message-ID: <20111205141746.31348.60583.stgit@localhost6.localdomain6> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00140.txt.bz2 The hardware breakpoint and watchpoint stuff do go through the target vector nowadays. Tested on x86_64-linux and applied. 2012-12-05 Pedro Alves gdb/ * amd64-linux-nat.c (amd64_linux_dr_get): Remove FIXME comment. Reinstate perror_with_name call on ptrace error. Remove #if 0. * i386-linux-nat.c (i386_linux_dr_get): Likewise. * i386bsd-nat.c (i386bsd_dr_get_status): Likewise. --- gdb/amd64-linux-nat.c | 9 --------- gdb/i386-linux-nat.c | 9 --------- gdb/i386bsd-nat.c | 9 --------- 3 files changed, 0 insertions(+), 27 deletions(-) diff --git a/gdb/amd64-linux-nat.c b/gdb/amd64-linux-nat.c index caf2e96..c673965 100644 --- a/gdb/amd64-linux-nat.c +++ b/gdb/amd64-linux-nat.c @@ -277,20 +277,11 @@ amd64_linux_dr_get (ptid_t ptid, int regnum) if (tid == 0) tid = PIDGET (ptid); - /* FIXME: kettenis/2001-03-27: Calling perror_with_name if the - ptrace call fails breaks debugging remote targets. The correct - way to fix this is to add the hardware breakpoint and watchpoint - stuff to the target vector. For now, just return zero if the - ptrace call fails. */ errno = 0; value = ptrace (PTRACE_PEEKUSER, tid, offsetof (struct user, u_debugreg[regnum]), 0); if (errno != 0) -#if 0 perror_with_name (_("Couldn't read debug register")); -#else - return 0; -#endif return value; } diff --git a/gdb/i386-linux-nat.c b/gdb/i386-linux-nat.c index 187c49d..7eb49ae 100644 --- a/gdb/i386-linux-nat.c +++ b/gdb/i386-linux-nat.c @@ -665,20 +665,11 @@ i386_linux_dr_get (ptid_t ptid, int regnum) if (tid == 0) tid = PIDGET (ptid); - /* FIXME: kettenis/2001-03-27: Calling perror_with_name if the - ptrace call fails breaks debugging remote targets. The correct - way to fix this is to add the hardware breakpoint and watchpoint - stuff to the target vector. For now, just return zero if the - ptrace call fails. */ errno = 0; value = ptrace (PTRACE_PEEKUSER, tid, offsetof (struct user, u_debugreg[regnum]), 0); if (errno != 0) -#if 0 perror_with_name (_("Couldn't read debug register")); -#else - return 0; -#endif return value; } diff --git a/gdb/i386bsd-nat.c b/gdb/i386bsd-nat.c index d46eaa4..fcd772f 100644 --- a/gdb/i386bsd-nat.c +++ b/gdb/i386bsd-nat.c @@ -312,18 +312,9 @@ i386bsd_dr_get_status (void) { struct dbreg dbregs; - /* FIXME: kettenis/2001-03-31: Calling perror_with_name if the - ptrace call fails breaks debugging remote targets. The correct - way to fix this is to add the hardware breakpoint and watchpoint - stuff to the target vector. For now, just return zero if the - ptrace call fails. */ if (ptrace (PT_GETDBREGS, PIDGET (inferior_ptid), (PTRACE_TYPE_ARG3) &dbregs, 0) == -1) -#if 0 perror_with_name (_("Couldn't read debug registers")); -#else - return 0; -#endif return DBREG_DRX ((&dbregs), 6); }