From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14386 invoked by alias); 5 Dec 2011 12:04:02 -0000 Received: (qmail 14356 invoked by uid 22791); 5 Dec 2011 12:04:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 12:03:48 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RXXGq-0002lS-US from pedro_alves@mentor.com ; Mon, 05 Dec 2011 04:03:45 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 5 Dec 2011 12:03:43 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: one-too-many location in breakpoint Date: Mon, 05 Dec 2011 12:04:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) Cc: Tom Tromey , Joel Brobecker , gdb-patches@sources.redhat.com References: <20111123163917.GA13809@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201112051203.41749.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00128.txt.bz2 On Tuesday 29 November 2011 16:58:38, Tom Tromey wrote: > Tom> I fixed all the other problems. I'm running a regression test to make > Tom> sure I didn't make something else break while doing this. If all goes > Tom> well I will send out refreshed patches. > > I needed a couple of test suite changes to account for the different > output. Otherwise all is well. > > This includes a test addition for the iterate_over_symbols change. > > I didn't write a new test for the "normal_menu" problem. /me catches breath after reading the whole thing. Can't say that was enough to completely grok it all, but nothing jumped out at me. FWIW. -- Pedro Alves From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14393 invoked by alias); 5 Dec 2011 12:04:03 -0000 Received: (qmail 14357 invoked by uid 22791); 5 Dec 2011 12:04:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 12:03:48 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RXXGq-0002lS-US from pedro_alves@mentor.com ; Mon, 05 Dec 2011 04:03:45 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 5 Dec 2011 12:03:43 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: one-too-many location in breakpoint Date: Mon, 05 Dec 2011 12:17:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-13-generic; KDE/4.7.2; x86_64; ; ) Cc: Tom Tromey , Joel Brobecker , gdb-patches@sources.redhat.com References: <20111123163917.GA13809@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-ID: <201112051203.41749.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00129.txt.bz2 Message-ID: <20111205121700.VrbKQfHB-GqqyfPoC0N_HsECotr_NJpsmVYOWvUvumk@z> On Tuesday 29 November 2011 16:58:38, Tom Tromey wrote: > Tom> I fixed all the other problems. I'm running a regression test to make > Tom> sure I didn't make something else break while doing this. If all goes > Tom> well I will send out refreshed patches. > > I needed a couple of test suite changes to account for the different > output. Otherwise all is well. > > This includes a test addition for the iterate_over_symbols change. > > I didn't write a new test for the "normal_menu" problem. /me catches breath after reading the whole thing. Can't say that was enough to completely grok it all, but nothing jumped out at me. FWIW. -- Pedro Alves