From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5141 invoked by alias); 4 Dec 2011 01:30:05 -0000 Received: (qmail 5109 invoked by uid 22791); 4 Dec 2011 01:30:04 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 04 Dec 2011 01:29:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB41TeCa004551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Dec 2011 20:29:40 -0500 Received: from host2.jankratochvil.net (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pB41TZBq031104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 3 Dec 2011 20:29:38 -0500 Date: Sun, 04 Dec 2011 01:30:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Pedro Alves , gdb-patches@sourceware.org, Kevin Pouget , Tom Tromey Subject: Re: ping: Re: [patch] Forbid "run" etc. for use_gdb_stub targets Message-ID: <20111204012935.GA4034@host2.jankratochvil.net> References: <201110271909.37066.pedro@codesourcery.com> <20111028174014.GB18885@host1.jankratochvil.net> <201110281917.44839.pedro@codesourcery.com> <20111029194745.GA12850@host1.jankratochvil.net> <20111203183613.GA15496@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00088.txt.bz2 On Sun, 04 Dec 2011 02:02:06 +0100, Doug Evans wrote: > I'd like to get away from conflating anything related to gdb stubs and > valgrind / gdbserver. Currently $use_gdb_stub means the startup has been already executed when the testsuite gets into GDB control. IIUC in reality currently the real stubs are not in use but gdbserver in non-extended mode behaves as native GDB with the stubs in the past. Maybe $use_gdb_stub name is not fortunate for what it does, real stubs are only subset of $use_gdb_stub cases. wrt valgrind, you may be referring to: http://sourceware.org/ml/gdb-patches/2011-10/msg00768.html # Therefore shouldn't be the gdb.server/ext-*.exp testfiles skipped if the # target board defined use_gdb_stub? (ext-attach.exp already is skipped, for # the [is_remote target] reason) [unreplied] Currently I did not change on the GDB testsuite behavior what was not clearly wrong. Therefore: * If a testcase can run only in some its specific mode/board of run: * Some testcases skip themselves if their mode/board is not satisfied. --- if [is_remote target] then { return 0 } * Some testcases enforce their mode/board no matter what mode has been specified by user for the testsuite. --- gdbserver_start_extended This creates duplicate runs of a testcase in the same mode/board if one runs the testsuite in multiple modes. * If a testcase is compatible with any mode/board it uses the mode/board specified by user for the testsuite. So far I just fixed those cases there were clearly wrong - such as spawning a gdbserver and then running new inferior locally in GDB. In the case of gdb.base/valgrind-db-attach.exp it enforces its mode and always runs. Thanks, Jan