Re: one-too-many location in breakpoint

Tom Tromey
2011-11-30T16:41:21Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> As discussed on IRC, there was one problem that I missed in the
Joel> proposals I made earlier. Attached is a patch that I wrote
Joel> which should solve that problem. In hindsight, perhaps I should
Joel> have split it in 2 or 3 patches, for instance one patch for
Joel> the new language method, and one patch for the rest.

I think one patch is fine. It is still easy to read.

Joel> With that patch, pretty much everything that I suggested, except
Joel> for the couple of issues I briefly mentioned (without describing
Joel> them), has been addressed. I'm not convinced yet that the remaining
Joel> issues have anything to do with the patch series but I will look
Joel> into that tomorrow.

The patch seems reasonable to me.

Joel> + make_cleanup (xfree, (void *) lookup_name);

You don't need the cast here.

Tom