From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85621-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9033 invoked by alias); 29 Nov 2011 03:14:15 -0000
Received: (qmail 9025 invoked by uid 22791); 29 Nov 2011 03:14:14 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 03:14:01 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 34FB32BB2D3;	Mon, 28 Nov 2011 22:14:01 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id 4b4Z57KwtYH6; Mon, 28 Nov 2011 22:14:01 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 097E92BB2D2;	Mon, 28 Nov 2011 22:14:01 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id D4378145615; Mon, 28 Nov 2011 22:13:47 -0500 (EST)
Date: Tue, 29 Nov 2011 03:14:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: decode_digits_line_mode (was: "Re: GDB 7.4 branching status? (2011-11-23)")
Message-ID: <20111129031347.GO24943@adacore.com>
References: <20111123163917.GA13809@adacore.com> <m38vn6y8v6.fsf@fleche.redhat.com> <20111123232406.GQ13809@adacore.com> <20111124105603.GA91879@adacore.com> <20111124163304.GR13809@adacore.com> <m31ussq6o2.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m31ussq6o2.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00798.txt.bz2

One tiny suggestion:

    s/decode_digits_line_mode/decode_digits_list_mode/

The function documentation talks about 'list_mode', and the call
to that function also checks self->list_mode:

    if (self->list_mode)
      decode_digits_line_mode (self, &values, val);

...

-- 
Joel