From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12077 invoked by alias); 27 Nov 2011 17:44:32 -0000 Received: (qmail 12069 invoked by uid 22791); 27 Nov 2011 17:44:31 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_DR X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Nov 2011 17:44:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 700E92BAFD4; Sun, 27 Nov 2011 12:44:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 80IuqCWCwxJJ; Sun, 27 Nov 2011 12:44:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 41A1D2BAFD3; Sun, 27 Nov 2011 12:44:14 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C2A43145615; Sun, 27 Nov 2011 12:44:03 -0500 (EST) Date: Sun, 27 Nov 2011 17:44:00 -0000 From: Joel Brobecker To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix build on sparc (remote.c/tracepoints) Message-ID: <20111127174403.GC24943@adacore.com> References: <20111126.143855.1966723588620210024.davem@davemloft.net> <20111126201404.GA24943@adacore.com> <20111126205107.GB24943@adacore.com> <4ED17954.7070602@earthlink.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="BwCQnh7xodEAoBMC" Content-Disposition: inline In-Reply-To: <4ED17954.7070602@earthlink.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00736.txt.bz2 --BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 610 > Heh, I sit down from around-the-house tasks thinking to commit my > fix, and Joel has it in hand already! There is one tweak I would > suggest: > > - sprintf_vma (addrbuf, loc->address); > - sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, addrbuf); > + sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, > + phex_nz (loc->address, > + gdbarch_addr_bit (target_gdbarch) / 8)); > > > Just use phex_nz (loc->address, 0) here, its builtin sizeof > calculation should be satisfactory. Hmm, yes, you're right. Thanks for the review. This is the patch that I just checked in. -- Joel --BwCQnh7xodEAoBMC Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="remote.c.diff" Content-length: 2281 commit d39c89d92ee7ed6afbf9f11398a566836e52bb17 Author: Joel Brobecker Date: Sun Nov 27 09:35:17 2011 -0800 remove use of sprintf_vma in remote_get_tracepoint_status This function takes a VMA and was forcing us to perform a cast to compile without warning on one platform. Except that the cast caused a warning on sparc-solaris. This patch fixes the problem by using phex_nz instead. gdb/ChangeLog: * remote.c (remote_get_tracepoint_status): Delete addrbuf local variable. Avoid use of sprintf_vma. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6fe2a5c..d6551d6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2011-11-27 Joel Brobecker + + * remote.c (remote_get_tracepoint_status): Delete addrbuf + local variable. Avoid use of sprintf_vma. + 2011-11-27 Sanjoy Das Fix regression in jit.exp. diff --git a/gdb/remote.c b/gdb/remote.c index 8fa5c1a..6e37f69 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -10219,7 +10219,6 @@ remote_get_tracepoint_status (struct breakpoint *bp, struct uploaded_tp *utp) { struct remote_state *rs = get_remote_state (); - char addrbuf[40]; char *reply; struct bp_location *loc; struct tracepoint *tp = (struct tracepoint *) bp; @@ -10234,8 +10233,8 @@ remote_get_tracepoint_status (struct breakpoint *bp, any status. */ if (tp->number_on_target == 0) continue; - sprintf_vma (addrbuf, loc->address); - sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, addrbuf); + sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, + phex_nz (loc->address, 0)); putpkt (rs->buf); reply = remote_get_noisy_reply (&target_buf, &target_buf_size); if (reply && *reply) @@ -10249,8 +10248,7 @@ remote_get_tracepoint_status (struct breakpoint *bp, { utp->hit_count = 0; utp->traceframe_usage = 0; - sprintf_vma (addrbuf, (long unsigned int) utp->addr); - sprintf (rs->buf, "qTP:%x:%s", utp->number, addrbuf); + sprintf (rs->buf, "qTP:%x:%s", utp->number, phex_nz (utp->addr, 0)); putpkt (rs->buf); reply = remote_get_noisy_reply (&target_buf, &target_buf_size); if (reply && *reply) --BwCQnh7xodEAoBMC--