> Heh, I sit down from around-the-house tasks thinking to commit my > fix, and Joel has it in hand already! There is one tweak I would > suggest: > > - sprintf_vma (addrbuf, loc->address); > - sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, addrbuf); > + sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, > + phex_nz (loc->address, > + gdbarch_addr_bit (target_gdbarch) / 8)); > > > Just use phex_nz (loc->address, 0) here, its builtin sizeof > calculation should be satisfactory. Hmm, yes, you're right. Thanks for the review. This is the patch that I just checked in. -- Joel