From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13914 invoked by alias); 25 Nov 2011 17:09:05 -0000 Received: (qmail 13905 invoked by uid 22791); 25 Nov 2011 17:09:04 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Nov 2011 17:08:48 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pAPH8hdo016529 for ; Fri, 25 Nov 2011 17:08:43 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAPH8hQM2539734 for ; Fri, 25 Nov 2011 17:08:43 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAPH8gb7004895 for ; Fri, 25 Nov 2011 10:08:43 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id pAPH8fVE004844; Fri, 25 Nov 2011 10:08:41 -0700 Message-Id: <201111251708.pAPH8fVE004844@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 25 Nov 2011 18:08:41 +0100 Subject: Re: [PATCH v3, alpha]: Handle single-stepping of atomic sequences To: ubizjak@gmail.com (Uros Bizjak) Date: Fri, 25 Nov 2011 17:09:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, amodra@gmail.com (Alan Modra), rth@redhat.com (Richard Henderson), Ulrich.Weigand@de.ibm.com (Ulrich Weigand) In-Reply-To: from "Uros Bizjak" at Nov 24, 2011 02:28:50 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00704.txt.bz2 Uros Bizjak wrote: > >> * alpha-tdep.c (br_opcode): New. > >> (ldl_l_opcode, ldq_l_opcode, stl_c_opcode, stq_c_opcode): Ditto. > >> (alpha_deal_with_atomic_sequence): New function. > >> (alpha_gdbarch_init): Handle single stepping of atomic sequences > >> with alpha_deal_with_atomic_sequence. > >> > >> [v3]: As suggested by Ulrich, handle all branch instructions inside > >> compare and exchange loop. > >> > >> Re-tested on alphaev68-pc-linux-gnu, also with simulate-thread.exp > >> from GCC testsuite. Looks good to me. Since Uros has no CVS access and asked me off-list to commit this patch, I've now done so. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com