From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27919 invoked by alias); 23 Nov 2011 16:41:09 -0000 Received: (qmail 27610 invoked by uid 22791); 23 Nov 2011 16:41:08 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate7.uk.ibm.com (HELO mtagate7.uk.ibm.com) (194.196.100.167) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 16:40:45 +0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pANGeh7h023546 for ; Wed, 23 Nov 2011 16:40:43 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pANGegxd2650230 for ; Wed, 23 Nov 2011 16:40:42 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pANGegwx031851 for ; Wed, 23 Nov 2011 09:40:42 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id pANGefc4031803; Wed, 23 Nov 2011 09:40:41 -0700 Message-Id: <201111231640.pANGefc4031803@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 23 Nov 2011 17:40:41 +0100 Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Wed, 23 Nov 2011 16:41:00 -0000 From: "Ulrich Weigand" Cc: andrew.smirnov@gmail.com, gdb-patches@sourceware.org In-Reply-To: <201111231636.pANGa165005809@glazunov.sibelius.xs4all.nl> from "Mark Kettenis" at Nov 23, 2011 05:36:01 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00621.txt.bz2 Mark Kettenis wrote: > > From: Andrey Smirnov > > Date: Tue, 22 Nov 2011 17:25:56 +0700 > > Subject: [PATCH 18/39] Fix -Wshadow warnings. > > > > * amd64-linux-tdep.c (amd64_canonicalize_syscall): Fix -Wshadow > > warnings. > > Why the hell does -Wshadow complain here? > > -amd64_canonicalize_syscall (enum amd64_syscall syscall) > > +amd64_canonicalize_syscall (enum amd64_syscall syscall_number) I'd expect this is because the parameter "syscall" shadows the global function declaration "syscall" provided by glibc headers: /usr/include/unistd.h:extern long int syscall (long int __sysno, ...) __THROW; Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com