From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7744 invoked by alias); 23 Nov 2011 14:42:00 -0000 Received: (qmail 7734 invoked by uid 22791); 23 Nov 2011 14:41:59 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 14:41:42 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id pANEfaxl006429; Wed, 23 Nov 2011 15:41:36 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id pANEfXDW022746; Wed, 23 Nov 2011 15:41:33 +0100 (CET) Date: Wed, 23 Nov 2011 14:42:00 -0000 Message-Id: <201111231441.pANEfXDW022746@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: davem@davemloft.net CC: gdb-patches@sourceware.org In-reply-to: <20111116.011217.835882743635387092.davem@davemloft.net> (message from David Miller on Wed, 16 Nov 2011 01:12:17 -0500 (EST)) Subject: Re: [PATCH] Fix build failure due to compiler warning. References: <20111116.011217.835882743635387092.davem@davemloft.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00614.txt.bz2 > Date: Wed, 16 Nov 2011 01:12:17 -0500 (EST) > From: David Miller > > On Sparc/Linux, __suseconds_t is not a type compatible with 'long' so > these printf statements trigger a warning and thus a build failure. > > This mirrors the casting already being done for the same exact reason > in vprintf_unfiltered. > > Ok to commit? Not sure if you already committed this, but "long int" sounds a bit pedantic, so I'd prefer to see this with "long". But either way, this is ok. > 2011-11-15 David S. Miller > > * utils.c (report_command_stats): Cast delta_wall_time 'tv_sec' and > 'tv_usec' to long for printf since these fields have a type which > varies.