From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Hector Oron <zumbi@debian.org>,
gdb-patches@sourceware.org,
Nobuhiro Iwamatsu <iwamatsu@debian.org>,
yoshii.takashi@renesas.com
Subject: Re: [PATCH] Renesas SH (sh4) native support
Date: Fri, 18 Nov 2011 15:55:00 -0000 [thread overview]
Message-ID: <20111118155522.GD2703@adacore.com> (raw)
In-Reply-To: <m34ny1ea5h.fsf@fleche.redhat.com>
> I glanced through the patch a little. It had the usual formatting
> issues, and was lacking ChangeLog entries, but otherwise nothing stood
> out for me.
The biggest issue I have besides copyright assignment (from the original
author, right?) is the fact that it hasn't been tested. If we could
involve the author a bit, and ask him to rebase the patch against
HEAD, and test it a bit, at least we could have a little bit of
confidence.
I've also spotted the following:
+#include <sys/ptrace.h>
+#include <sys/types.h>
+#include <sys/param.h>
+#include <sys/user.h>
+#include <sys/syscall.h>
+
+#include <asm/ptrace.h>
which is a big no-no in a -tdep file. Tdep files should be compilable
on any host.
I haven't been able to review the file much beyond that...
--
Joel
next prev parent reply other threads:[~2011-11-18 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 23:20 Hector Oron
2011-11-18 0:13 ` Hector Oron
2011-11-18 15:14 ` Tom Tromey
2011-11-18 15:55 ` Joel Brobecker [this message]
2011-11-18 16:13 ` Hector Oron
2011-11-18 21:46 ` Nobuhiro Iwamatsu
2011-11-18 16:37 ` Mike Frysinger
2011-11-18 21:46 ` Nobuhiro Iwamatsu
2011-11-20 7:10 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118155522.GD2703@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=iwamatsu@debian.org \
--cc=tromey@redhat.com \
--cc=yoshii.takashi@renesas.com \
--cc=zumbi@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox