Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: DJ Delorie <dj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [sim] new port: Renesas RL78
Date: Thu, 17 Nov 2011 19:53:00 -0000	[thread overview]
Message-ID: <201111171452.49448.vapier@gentoo.org> (raw)
In-Reply-To: <201111171947.pAHJlsYD005315@greed.delorie.com>

[-- Attachment #1: Type: Text/Plain, Size: 395 bytes --]

On Thursday 17 November 2011 14:47:54 DJ Delorie wrote:
> +      for (i=0; i<32; i++)

seems many of the for loops in here need to have spaces added around their 
operators.
	for (i = 0; i < 32; i++)

otherwise, didn't really see anything else from scanning through.  other than 
my overall comment that it'd be nice if this used common/ instead of doing 
everything itself ;).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-11-17 19:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16  6:07 DJ Delorie
2011-11-16 19:09 ` Mike Frysinger
2011-11-16 19:36   ` DJ Delorie
2011-11-16 19:47     ` Mike Frysinger
2011-11-16 21:45       ` Mike Frysinger
2011-11-17 19:16   ` DJ Delorie
2011-11-17 19:39     ` Mike Frysinger
2011-11-17 19:48       ` DJ Delorie
2011-11-17 19:53         ` Mike Frysinger [this message]
2011-11-17 21:34           ` DJ Delorie
2011-11-17 21:44             ` Mike Frysinger
2011-11-28 20:03 ` DJ Delorie
2011-11-28 20:13   ` Mike Frysinger
2011-11-28 21:01   ` Stan Shebs
2011-11-28 21:16     ` DJ Delorie
2011-11-29  3:50     ` DJ Delorie
2011-11-29  4:08       ` Eli Zaretskii
2011-11-29  1:38 ` Mike Frysinger
2012-03-23  4:33 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111171452.49448.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=dj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox