From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14152 invoked by alias); 16 Nov 2011 19:47:47 -0000 Received: (qmail 14143 invoked by uid 22791); 16 Nov 2011 19:47:46 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Nov 2011 19:47:28 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D8F891B4006; Wed, 16 Nov 2011 19:47:27 +0000 (UTC) From: Mike Frysinger To: DJ Delorie Subject: Re: [sim] new port: Renesas RL78 Date: Wed, 16 Nov 2011 19:47:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201111160606.pAG66U4p017015@greed.delorie.com> <201111161409.19823.vapier@gentoo.org> <201111161936.pAGJaKfW006960@greed.delorie.com> In-Reply-To: <201111161936.pAGJaKfW006960@greed.delorie.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2164452.mzratR7Tjh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201111161447.29112.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00448.txt.bz2 --nextPart2164452.mzratR7Tjh Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 2220 On Wednesday 16 November 2011 14:36:20 DJ Delorie wrote: > > > + $(ENDLIST) > >=20 > > this $(ENDLIST) business looks like dead code ? >=20 > I've been brainwashed to end lists like this so that new lines always > end with a continuation char, which - in ancient and possibly modern > source control systems - prevents two independent additions from > becoming dependent on each other. It also allows you to sort or > otherwise mess with the list, without worrying about which lines have > continuation characters and which don't. sounds like it should be a standard in the wider binutils/gdb/etc... tree, = or=20 should be omitted and forgotten about. all these youngsters don't have a c= lue=20 what "$(ENDLIST)" is for, and heaven forbid someone has ENDLIST exported in= =20 their env when running `make` ;). > > > +int > > > +main (int argc, char **argv) > > > +{ > > > ... > > > + setbuf(stdout, NULL); > >=20 > > doesn't this hurt performance ? especially when tracing ? >=20 > Very important when emulating the target serial port, though. I > suppose I could rework that logic, but so far I've mostly been worried > about "runs correctly" and not "runs fast". hmm, personally i've left that up to the host to run `stty` rather than=20 mucking about with terminal settings on people. although that covers input= =20 and not output. for output, i have my uart simulator explicitly flush whenever it has data = to=20 right. that way general things writing to stdout don't take a penalty, but= =20 the serial which wants bytes sent immediately still work. > > > --- /dev/null 1 Jan 1970 00:00:00 -0000 > > > +++ sim/rl78/mem.c 16 Nov 2011 05:44:54 -0000 > >=20 > > seems like much of the utility of this file is duplicating the core > > mapping=3D s=3D20 > > logic in like common/sim-core.c :/ >=20 > It's mostly about emulating memory-mapped hardware and the weird RL78 > mapping rules, though. The common parts are a small part of it. common/ provides frameworks for emulating memory mapped devices :). the=20 Blackfin port uses this heavily so that specific devices are cleanly manage= d in=20 sep files. see all the fun bfin/dv-* files. although converting to that is probably non-trivial. -mike --nextPart2164452.mzratR7Tjh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOxBNRAAoJEEFjO5/oN/WBa98QALnwBYp/+AC+wfjQBXwepvDT hI5EK7bqDp7vUL7eX6IS/+hDonWDTFBmrWt1XMUcqa1+QhHuSLonnIBNm2BFSthX 5VkVtc2MIL2SkJisdyYEdHrVKpu4Cdzr3Y9vcKOQkVSlvHcfeftBhiItg7Dfllq3 eqNALHl7AGVvZTzzK9Nyzoh7SLPL/8x1KCJAkWDeWkaLU/f418tFMbB3XHAlJxtC M0dgtib1X4UBdPIlFRHm0cxXW7CwcCuO4IwoQQMRSEqqLwVSmItz/YjEG7mWwz52 ToKBXBwMAU+eP9JYUVpPtEo4ruTrRICSla05VkUl5fSTZzhswBrWQJ+wkJXA7er8 IZ2D6+TRJUJjQl3rBeAP+PzcDqI/r6us5IjjCcy7LnQG4mg3BobTANhtfXgSjYcn 7J31mfnb++pDCw3Ee7+hrDwRH2mUEQAmA1pxomnExjYeOFY6K03+Lr0HLwZojGA1 9valPK6V1/rECHQ9OiWcG6/U13looaq5wAueQ4wKN5ls8qBCZX/QR38mo/BphNt7 9m/P7ZEoUKQhN92sxG/8bbajKTwI0KeWf+IHCxLLOf0NZYKKLQThBB2wwD+yMRGw F41mc1zB2oHfea4gvgwAt0938pPaW1//LPMDg9LRhJ68wM42ZPOlzNsMp8EFW+Mn T6anBcSPcWIoPpoA2RI+ =Djt+ -----END PGP SIGNATURE----- --nextPart2164452.mzratR7Tjh--