From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1990 invoked by alias); 14 Nov 2011 12:24:41 -0000 Received: (qmail 1969 invoked by uid 22791); 14 Nov 2011 12:24:37 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 12:24:24 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RPvaJ-0006hy-35 from pedro_alves@mentor.com for gdb-patches@sourceware.org; Mon, 14 Nov 2011 04:24:23 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 14 Nov 2011 12:24:21 +0000 From: Pedro Alves To: Yao Qi Subject: Re: [patch 4/8] Download tracepoint locations and track its status Date: Mon, 14 Nov 2011 12:24:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <4EB8C551.9090609@codesourcery.com> <201111101551.20428.pedro@codesourcery.com> <4EBDD5BA.4090405@codesourcery.com> In-Reply-To: <4EBDD5BA.4090405@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111141224.19819.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00347.txt.bz2 On Saturday 12 November 2011 02:11:06, Yao Qi wrote: > 0004-tracepoint-change-loc.patch > * breakpoint.h (struct bp_location): Add comment on field > `duplicate'. > * breakpoint.c (should_be_inserted): Don't differentiate breakpoint > and tracepoint. > (remove_breakpoints): Don't remove tracepoints. > (tracepoint_locations_match ): New. > (breakpoint_locations_match): Call it. > (disable_breakpoints_in_unloaded_shlib): Handle tracepoint. > (download_tracepoint_locations): New. > (update_global_location_list): Call it. > * tracepoint.c (find_matching_tracepoint): Delete. > (find_matching_tracepoint_location): Renamed from > find_matching_tracepoint. Return bp_location rather than > tracepoint. > (merge_uploaded_tracepoints): Set `inserted' field to 1 if > tracepoint is found. This version is okay, thanks. -- Pedro Alves