From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8119 invoked by alias); 12 Nov 2011 00:28:29 -0000 Received: (qmail 8110 invoked by uid 22791); 12 Nov 2011 00:28:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 Nov 2011 00:28:14 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RP1S9-0000wV-M0 from pedro_alves@mentor.com ; Fri, 11 Nov 2011 16:28:13 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Sat, 12 Nov 2011 00:28:11 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH - TUI and Insight Related] Fix for PR13378 Date: Sat, 12 Nov 2011 00:28:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: Sterling Augustine References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111120028.09459.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00336.txt.bz2 On Friday 11 November 2011 20:53:59, Sterling Augustine wrote: > Hi, > > Enclosed is a very simple patch which fixes the annoying TUI-updating > issue described in > http://sourceware.org/bugzilla/show_bug.cgi?id=13378. > > It simply eliminates a call to > deprecated_selected_frame_level_changed_hook. This hook has been > deprecated for many years, so one would think it's clients have had > time to remove the dependency. Sorry, this approach is backwards. We should stop TUI from installing the hook first instead. Then when all users have disappeared, we can eliminate the hook. > After using it locally for a week now, > I see no ill effects in TUI. stopping at breakpoints, up, down, and > the other stuff all work fine for me. However, the testsuite is, err, > incomplete on this feature. I've tried it, and that's unfortunately not true -- TUI no longer reacts to up/down. The right fix is adding a new observer for when the user changes the frame, and make TUI use it instead of this hook that triggers all too often. I thought MI had such an observer, but I guess that was some discussion that never got anywhere or a patch that never got in. -- Pedro Alves