From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10388 invoked by alias); 10 Nov 2011 19:41:52 -0000 Received: (qmail 10372 invoked by uid 22791); 10 Nov 2011 19:41:50 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 19:41:34 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ROaVC-0006u0-0n from pedro_alves@mentor.com for gdb-patches@sourceware.org; Thu, 10 Nov 2011 11:41:34 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 10 Nov 2011 19:41:31 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Increase the bar of printing `handling possible serial event' Date: Thu, 10 Nov 2011 19:41:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: Yao Qi References: <4EBB6ED6.7050408@codesourcery.com> In-Reply-To: <4EBB6ED6.7050408@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201111101941.30469.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00296.txt.bz2 On Thursday 10 November 2011 06:27:34, Yao Qi wrote: > Hi, > When I debug gdbserver by setting debug_thread to 1, I get many lines > of `handling possible serial event' in log, which dose not carry any > useful information for debugging purpose. > > This patch is to increase the threshold of printing this sentence. Or we > may remove this print completely, because I can't figure out a case > some one wants to read many lines of `handling possible serial event' > in log. I've found it more than once very useful when debugging non-stop/async mode issues, where the order of serial and target events isn't predictable, and knowing when a packet was just handled can help figure out following weird behaviors. If it bothers so much, I could go with outputting it only when non_stop is on. Just bumping is not good, because you can't set debug_thread to anything other than 1 or 0 without recompiling gdbserver, and that's not good when asking users for logs. -- Pedro Alves