Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA/ping] 12843
Date: Thu, 10 Nov 2011 18:13:00 -0000	[thread overview]
Message-ID: <20111110181249.GD5390@adacore.com> (raw)
In-Reply-To: <4EBC06AD.6050205@redhat.com>

> -	  || p[0] == '\t'
> -	  || (p[0] == ':')
> +	  || p[0] == '\t' || p[0] == ':'

I wish reformatting changes like this were made separately.
Usually, they can even be checked in under the obvious rule...
In this case, not so sure - I like the previous formatting better,
because each branch of the multiple-or was on its own line.
But don't change it on my account, it's not terribly important.

-- 
Joel


  parent reply	other threads:[~2011-11-10 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 17:15 Keith Seitz
2011-11-10 17:22 ` Tom Tromey
2011-11-10 18:13 ` Joel Brobecker [this message]
2011-11-10 18:36   ` Keith Seitz
2011-11-11 19:57     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111110181249.GD5390@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox