From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3538 invoked by alias); 9 Nov 2011 18:30:53 -0000 Received: (qmail 3528 invoked by uid 22791); 9 Nov 2011 18:30:52 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 18:30:37 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ROCuy-00025R-8K from pedro_alves@mentor.com ; Wed, 09 Nov 2011 10:30:36 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 9 Nov 2011 18:30:34 +0000 From: Pedro Alves To: Tom Tromey Subject: Re: RFC: don't set the pspace on ordinary breakpoints Date: Wed, 09 Nov 2011 18:30:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Ulrich Weigand References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111091830.31856.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00248.txt.bz2 On Tuesday 08 November 2011 20:23:13, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > Tom> I think I will change linespec to ignore program spaces in this state. > > The appended has two parts: the linespec.c change, relative to the big > patch I posted, and the breakpoint.c change I think is needed too. Only > the latter makes sense in the context of this thread. > > I *think* the should_be_inserted change is all that was really needed, > after re-reading all the messages in this thread. Let me know what you > think. I think so, but it's hard to tell, given that the dependency on the linespec.c changes. E.g., > @@ -1327,6 +1329,12 @@ decode_indirect (struct linespec_state *self, char **argptr) > CORE_ADDR pc; > char *initial = *argptr; > > + if (current_program_space->executing_startup) > + /* The error message doesn't really matter, because this case > + should only hit during breakpoint reset. */ > + throw_error (NOT_FOUND_ERROR, _("cannot evaluate expressions while " > + "program space is in startup")); Why is is okay to look at current_program_space here, if you're iterating over pspaces elsewhere? Any chance we can have a standalone patch for just the startup-disabled changes? We'd need something like my previous suggestion in bkpt_re_set (even if we'd remain buggy WRT multi-process). -- Pedro Alves