From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24348 invoked by alias); 9 Nov 2011 18:18:46 -0000 Received: (qmail 24330 invoked by uid 22791); 9 Nov 2011 18:18:45 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,TW_CP X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 18:18:30 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pA9IISM7026610; Wed, 9 Nov 2011 18:18:28 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA9IISAj1966162; Wed, 9 Nov 2011 18:18:28 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA9IIR6F005499; Wed, 9 Nov 2011 11:18:27 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id pA9IIQ5F005486; Wed, 9 Nov 2011 11:18:26 -0700 Message-Id: <201111091818.pA9IIQ5F005486@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 09 Nov 2011 19:18:26 +0100 Subject: Re: [rfc][1/3] Remote core file generation: BFD support To: pedro@codesourcery.com (Pedro Alves) Date: Wed, 09 Nov 2011 18:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, binutils@sourceware.org In-Reply-To: <201111091600.30812.pedro@codesourcery.com> from "Pedro Alves" at Nov 09, 2011 04:00:30 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00242.txt.bz2 Pedro Alves wrote: > On Friday 21 October 2011 19:56:09, Ulrich Weigand wrote: > > > Index: bfd/elf32-arm.c > > =================================================================== > > RCS file: /cvs/src/src/bfd/elf32-arm.c,v > > retrieving revision 1.278 > > diff -u -p -r1.278 elf32-arm.c > > --- bfd/elf32-arm.c 19 Oct 2011 07:17:13 -0000 1.278 > > +++ bfd/elf32-arm.c 21 Oct 2011 16:49:54 -0000 > > @@ -1986,6 +1986,55 @@ elf32_arm_nabi_grok_psinfo (bfd *abfd, E > > return TRUE; > > } > > > > +static char * > > +elf32_arm_nabi_write_core_note (bfd *abfd, char *buf, int *bufsiz, > > + int note_type, ...) > > +{ > > + switch (note_type) > > + { > > + default: > > + return NULL; > > + > > + case NT_PRPSINFO: > > + { > > + char data[124]; > > + va_list ap; > > + > > + va_start (ap, note_type); > > + memset (data, 0, 28); > > + strncpy (data + 28, va_arg (ap, const char *), 16); > > + strncpy (data + 44, va_arg (ap, const char *), 80); > > The `data' buffer should be zero initialized, to avoid > leaving garbage on the core, when the passed in fname and > psargs are less than 16 and 80 bytes long respectively. > It's true the caller does that itself today, but > your patch 2 (rightly) makes it not do so anymore. OK, good point. I've just copied this from the PowerPC implementation, which needs to be fixed as well ... I'll provide an updated patch. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com