From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 351 invoked by alias); 7 Nov 2011 21:24:44 -0000 Received: (qmail 337 invoked by uid 22791); 7 Nov 2011 21:24:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 21:24:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7DBE12BB164; Mon, 7 Nov 2011 16:24:27 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MPZnKehFM0Rq; Mon, 7 Nov 2011 16:24:27 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 50C712BB130; Mon, 7 Nov 2011 16:24:27 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9C2A9145615; Mon, 7 Nov 2011 16:24:20 -0500 (EST) Date: Mon, 07 Nov 2011 21:24:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA] read_frame_register_value and big endian arches Message-ID: <20111107212420.GJ14508@adacore.com> References: <20111026213726.GV19246@adacore.com> <1320022996-14705-1-git-send-email-brobecker@adacore.com> <201111071941.41988.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201111071941.41988.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00163.txt.bz2 Hi Pedro, > > gdb/ChangeLog: > > > > * findvar.c (read_frame_register_value): Read the correct bytes > > from registers on big-endian architectures. > > Looks good to me. Thanks for double-checking my change... > > +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug optimize=-O1]] != "" } { > > Does the test really depend on the compiler doing the right optimizations? Yes. I haven't looked at the unoptimized version, but my guess is that the parameter value gets immediately pushed to the stack, thus hiding the problem. -- Joel