From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21961 invoked by alias); 7 Nov 2011 19:42:05 -0000 Received: (qmail 21951 invoked by uid 22791); 7 Nov 2011 19:42:04 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 19:41:47 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RNV4k-0005ir-G0 from pedro_alves@mentor.com ; Mon, 07 Nov 2011 11:41:46 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 7 Nov 2011 19:41:44 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] read_frame_register_value and big endian arches Date: Mon, 07 Nov 2011 19:42:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: Joel Brobecker References: <20111026213726.GV19246@adacore.com> <1320022996-14705-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1320022996-14705-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111071941.41988.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00162.txt.bz2 Hi Joel, On Monday 31 October 2011 01:03:16, Joel Brobecker wrote: > gdb/ChangeLog: > > * findvar.c (read_frame_register_value): Read the correct bytes > from registers on big-endian architectures. Looks good to me. > +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug optimize=-O1]] != "" } { Does the test really depend on the compiler doing the right optimizations? -- Pedro Alves