From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17574 invoked by alias); 7 Nov 2011 15:08:41 -0000 Received: (qmail 17564 invoked by uid 22791); 7 Nov 2011 15:08:37 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 15:08:04 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RNQnr-0004ol-C9 from pedro_alves@mentor.com ; Mon, 07 Nov 2011 07:08:03 -0800 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 7 Nov 2011 15:08:01 +0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Run tests in gdb.reverse Date: Mon, 07 Nov 2011 15:08:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: Tom Tromey , Yao Qi References: <4EB69AE6.4010301@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201111071507.58347.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00151.txt.bz2 On Monday 07 November 2011 14:54:28, Tom Tromey wrote: > >>>>> "Yao" == Yao Qi writes: > > Yao> During reviewing "arm reverse debugging" patch, we realize that tests in > Yao> gdb.reverse are not run in common regression test unless we set some > Yao> variables in board file. > > Yao> This patch is to convert variable checking in each reverse test case to > Yao> a proc return value checking, so that gdb.reverse tests will be run on > Yao> targets that support reverse debugging. > > Thanks for doing this. > > Yao> +proc support_process_record {} { > Yao> + > Yao> + if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } { > > It seems to me that both of the new procs should include the old check > using target_info as well, just in case. This will avoid breaking > anybody's existing setup. Yes, we need to be able to run the reverse tests against remote targets that support reverse debugging themselves. E.g., simulators. Those can do reverse debugging on their own, target record is not involved. Can we make predicates supportS_FOO (add an S)? support_FOO reads as an action to me. -- Pedro Alves