From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17763 invoked by alias); 3 Nov 2011 17:07:00 -0000 Received: (qmail 17755 invoked by uid 22791); 3 Nov 2011 17:06:59 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 17:06:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA3H6U7i001328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Nov 2011 13:06:32 -0400 Received: from host1.jankratochvil.net (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA3H6Q87019063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Nov 2011 13:06:28 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id pA3H6P2K022938; Thu, 3 Nov 2011 18:06:25 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id pA3H6Odf022937; Thu, 3 Nov 2011 18:06:24 +0100 Date: Thu, 03 Nov 2011 17:07:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, sergiodj@redhat.com Subject: Re: [patch] `info proc *' help fix [Re: [patch] `info proc ' completion] Message-ID: <20111103170624.GA22871@host1.jankratochvil.net> References: <20111031070012.GA32610@host1.jankratochvil.net> <201110311220.53564.pedro@codesourcery.com> <20111101115405.GA15861@host1.jankratochvil.net> <83pqhbn771.fsf@gnu.org> <20111103141144.GA20181@host1.jankratochvil.net> <83aa8dm9f3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83aa8dm9f3.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00083.txt.bz2 On Thu, 03 Nov 2011 17:56:48 +0100, Eli Zaretskii wrote: > > add_cmd ("stat", class_info, linux_nat_info_proc_cmd_stat, _("\ > > -List a bunch of random process info."), > > +List annotated random process info from /proc/PID/stat."), > > &info_proc_cmdlist); > > I would suggest > > List process info from /proc/PID/stat. > > > -List a different bunch of random process info."), > > +List a different bunch of random process info from /proc/PID/status."), > > And likewise here. The problem is each `info proc XXX' commands reads it in /proc/PID/XXX file, which may be obvious. But I understand "stat" and "status" may be an exception as it is difficult to describe what /proc/PID/{stat,status} contain. I assume you meant it this way but asking again. Thanks, Jan gdb/ 2011-11-03 Jan Kratochvil Eli Zaretskii * linux-nat.c (_initialize_linux_nat): Improve help for `info proc stat', `info proc status', `info proc cwd', `info proc cmdline' and `info proc exe'. --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -5887,23 +5887,23 @@ List of mapped memory regions."), &info_proc_cmdlist); add_cmd ("stat", class_info, linux_nat_info_proc_cmd_stat, _("\ -List a bunch of random process info."), +List process info from /proc/PID/stat."), &info_proc_cmdlist); add_cmd ("status", class_info, linux_nat_info_proc_cmd_status, _("\ -List a different bunch of random process info."), +List process info from /proc/PID/status."), &info_proc_cmdlist); add_cmd ("cwd", class_info, linux_nat_info_proc_cmd_cwd, _("\ -List a different bunch of random process info."), +List current working directory of the process."), &info_proc_cmdlist); add_cmd ("cmdline", class_info, linux_nat_info_proc_cmd_cmdline, _("\ -List a different bunch of random process info."), +List command line arguments of the process."), &info_proc_cmdlist); add_cmd ("exe", class_info, linux_nat_info_proc_cmd_exe, _("\ -List a different bunch of random process info."), +List absolute filename for executable of the process."), &info_proc_cmdlist); add_cmd ("all", class_info, linux_nat_info_proc_cmd_all, _("\