From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7829 invoked by alias); 3 Nov 2011 16:55:48 -0000 Received: (qmail 7819 invoked by uid 22791); 3 Nov 2011 16:55:47 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 16:55:25 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA3GtOn7031112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Nov 2011 12:55:24 -0400 Received: from host1.jankratochvil.net (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA3GtM7T029742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Nov 2011 12:55:24 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id pA3GtLjx016345; Thu, 3 Nov 2011 17:55:21 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id pA3GtLQT016344; Thu, 3 Nov 2011 17:55:21 +0100 Date: Thu, 03 Nov 2011 16:55:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: Michael Eager , "gdb-patches@sourceware.org" Subject: Re: SEGV in dwarf2read.c -- gdb-7.2 Message-ID: <20111103165521.GA16221@host1.jankratochvil.net> References: <4EB2BD58.3080003@eagerm.com> <20111103162026.GA12269@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00080.txt.bz2 On Thu, 03 Nov 2011 17:43:20 +0100, Tom Tromey wrote: > Does the CU cache serve a useful purpose these days? You already need to pre-read all the CUs (=load_cu) before starting to parse them (=process_queue). So some multi-CU storage needs to be there. It is true the cache should be at least significantly larger (now dwarf2_max_cache_age == 5 generations) to have any effect, if it can have any effect. > I wonder whether we could just remove it. But the code does not get much simplified without the cache IMO (sure one should benchmark it), there is still needed tracking of the multipled read in CUs etc. Regards, Jan