From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22989 invoked by alias); 2 Nov 2011 18:30:57 -0000 Received: (qmail 22979 invoked by uid 22791); 2 Nov 2011 18:30:56 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 18:30:42 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RLfaD-0002S8-HI from pedro_alves@mentor.com ; Wed, 02 Nov 2011 11:30:41 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 2 Nov 2011 18:30:39 +0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] `info proc ' completion [Re: [PATCH] Implement new `info core mappings' command] Date: Wed, 02 Nov 2011 18:30:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-12-generic; KDE/4.7.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Sergio Durigan Junior References: <201110311220.53564.pedro@codesourcery.com> <20111101115405.GA15861@host1.jankratochvil.net> In-Reply-To: <20111101115405.GA15861@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111021830.37449.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00046.txt.bz2 On Tuesday 01 November 2011 11:54:05, Jan Kratochvil wrote: > On Mon, 31 Oct 2011 13:20:53 +0100, Pedro Alves wrote: > > I once wrote a patch for that. /me *looks for it* > > Rebased and cleaned up the diff. > > > > The reason I never pushed it is that "info proc" handles > > more than one keyword at the same time. E.g., > > "info proc cmdline cwd" displays both cmdline and cwd > > info simultaneously. That doesn't work if you have a > > command per keyword. > > I did not know that, the doc does not mention it and such feature is very > easily "workaroundable", I do not think it can be compared to he inconvenience > of the current state. I agree. > OTOH I do not understand what is it good for when one has shell but if the > feature is already there... Yeah... > + int stat_f = (what == IP_STAT || what == IP_ALL); Extra space. > + while (args && isspace (*args)) > + args++; args = skip_spaces (args); > + if (args && args[0]) > + error (_("Too many parameters: %s"), args); -- Pedro Alves