From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7760 invoked by alias); 28 Oct 2011 02:09:35 -0000 Received: (qmail 7530 invoked by uid 22791); 28 Oct 2011 02:09:34 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Oct 2011 02:09:20 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9S29Jo8017933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Oct 2011 22:09:20 -0400 Received: from host1.jankratochvil.net (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9S29HJe018675 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 27 Oct 2011 22:09:19 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9S29GWm023270; Fri, 28 Oct 2011 04:09:16 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9S29Eur022658; Fri, 28 Oct 2011 04:09:14 +0200 Date: Fri, 28 Oct 2011 03:40:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] document that check_typedef can throw an exception Message-ID: <20111028020913.GA4765@host1.jankratochvil.net> References: <20111027215551.97B0C246191@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111027215551.97B0C246191@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00755.txt.bz2 On Thu, 27 Oct 2011 23:55:51 +0200, Doug Evans wrote: [...] > * gdbtypes.c (check_typedef): Document that this function can > throw an exception. [...] > + NOTE: Lookup of types for opaque types can throw some errors during > + invalid symbol files. Thus this function can throw an exception. Always by expanding opaque types: Either lookup_symbol_aux_quick: error (_("\ Internal: %s symbol `%s' found in %s psymtab but not in symtab.\n\ which is not completely correct but it was commonly happenning and it still may happen. Or just RETURN_QUIT from new CUs being expanded ...->dwarf2_compute_name->c_print_type->... (there some QUIT; statements). Regards, Jan