From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16230 invoked by alias); 27 Oct 2011 21:56:18 -0000 Received: (qmail 16137 invoked by uid 22791); 27 Oct 2011 21:56:15 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Oct 2011 21:55:55 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id p9RLtrIJ005668; Thu, 27 Oct 2011 14:55:53 -0700 Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.110.50]) by hpaq14.eem.corp.google.com with ESMTP id p9RLtpAt011857; Thu, 27 Oct 2011 14:55:52 -0700 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id 97B0C246191; Thu, 27 Oct 2011 14:55:51 -0700 (PDT) To: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: [patch] document that check_typedef can throw an exception Message-Id: <20111027215551.97B0C246191@ruffy.mtv.corp.google.com> Date: Thu, 27 Oct 2011 22:03:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00752.txt.bz2 Hi. I will check this in in a few days if there are no objections. 2011-10-27 Doug Evans * gdbtypes.c (check_typedef): Document that this function can throw an exception. Index: gdbtypes.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.c,v retrieving revision 1.220 diff -u -p -r1.220 gdbtypes.c --- gdbtypes.c 14 Oct 2011 20:22:17 -0000 1.220 +++ gdbtypes.c 27 Oct 2011 21:53:52 -0000 @@ -1454,6 +1454,9 @@ stub_noname_complaint (void) not been computed and we're either in the middle of reading symbols, or there was no name for the typedef in the debug info. + NOTE: Lookup of types for opaque types can throw some errors during + invalid symbol files. Thus this function can throw an exception. + If TYPE is a TYPE_CODE_TYPEDEF, its length is updated to the length of the target type.