From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7535 invoked by alias); 27 Oct 2011 17:51:20 -0000 Received: (qmail 7524 invoked by uid 22791); 27 Oct 2011 17:51:19 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Oct 2011 17:51:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B89E02BAC39; Thu, 27 Oct 2011 13:51:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nK3mECt-NVGD; Thu, 27 Oct 2011 13:51:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8D25C2BABC2; Thu, 27 Oct 2011 13:51:02 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DFC6E145615; Thu, 27 Oct 2011 13:50:57 -0400 (EDT) Date: Thu, 27 Oct 2011 17:56:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA/RFC] Restore old handling of multi-register variables Message-ID: <20111027175057.GB19246@adacore.com> References: <1317675787-7351-1-git-send-email-brobecker@adacore.com> <201110252149.34078.pedro@codesourcery.com> <20111026213726.GV19246@adacore.com> <201110271159.10997.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110271159.10997.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00741.txt.bz2 > > gdb/ChangeLog: > > > > * value.h (read_frame_register_value): Add declaration. > > * findvar.c (read_frame_register_value): New function. > > (value_from_register): Use read_frame_register_value > > instead of get_frame_register_value + value_contents_copy > > to get value contents. > > > > Tested on AVR using AdaCore's testsuite. Tested on x86_64-linux > > using the official testsuite. > > Looks good to me. Thanks! Checked in. -- Joel