From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18779 invoked by alias); 27 Oct 2011 10:59:35 -0000 Received: (qmail 18770 invoked by uid 22791); 27 Oct 2011 10:59:35 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Oct 2011 10:59:15 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RJNg2-0006V6-7p from pedro_alves@mentor.com ; Thu, 27 Oct 2011 03:59:14 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 27 Oct 2011 11:59:11 +0100 From: Pedro Alves To: Joel Brobecker Subject: Re: [RFA/RFC] Restore old handling of multi-register variables Date: Thu, 27 Oct 2011 11:10:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1317675787-7351-1-git-send-email-brobecker@adacore.com> <201110252149.34078.pedro@codesourcery.com> <20111026213726.GV19246@adacore.com> In-Reply-To: <20111026213726.GV19246@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110271159.10997.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00724.txt.bz2 On Wednesday 26 October 2011 22:37:26, Joel Brobecker wrote: > Here is a new version of the patch that reads values over multiple > registers if needed. You suggested that read_frame_register_value > should be in frame.c, but it seemed more logical to put it in findvar. > I think that the proximity with the ther frame_register routines > made it more natural, whereas I couldn't find a natural place where > the new routine would fit in frame.c. > But I can move it to frame.c if you think it's a better place. That's fine. As long as it's not in value.c :-). findvar.c is a weird file. It seems to contains a mix of two or three different things. But that's precedent. > gdb/ChangeLog: > > * value.h (read_frame_register_value): Add declaration. > * findvar.c (read_frame_register_value): New function. > (value_from_register): Use read_frame_register_value > instead of get_frame_register_value + value_contents_copy > to get value contents. > > Tested on AVR using AdaCore's testsuite. Tested on x86_64-linux > using the official testsuite. > > OK? Looks good to me. -- Pedro Alves