From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20516 invoked by alias); 26 Oct 2011 13:49:28 -0000 Received: (qmail 20498 invoked by uid 22791); 26 Oct 2011 13:49:25 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_BJ X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Oct 2011 13:49:05 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1RJ3qr-0003i8-2k from pedro_alves@mentor.com ; Wed, 26 Oct 2011 06:49:05 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 26 Oct 2011 14:49:02 +0100 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] gdb.python/py-events.exp: Disable multi-inferior for gdbserver [Re: Regression (or a new FAIL?): gdb.python/py-events.exp] Date: Wed, 26 Oct 2011 15:07:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.1; x86_64; ; ) Cc: Jan Kratochvil , Kevin Pouget , Tom Tromey References: <20111009181654.GA4629@host1.jankratochvil.net> In-Reply-To: <20111009181654.GA4629@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110261448.58804.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00695.txt.bz2 On Sunday 09 October 2011 19:16:54, Jan Kratochvil wrote: > On Wed, 05 Oct 2011 16:55:28 +0200, Kevin Pouget wrote: > > what do you want me to do with that, certainly fill a bug report, > > shall I change anything in my patch? > > I realized gdbserver supports multi-inferior by attaching each new inferior > but it does not yet support (=remote.c ignores) `set detach-on-fork off' at > all. Right, there's no support for following forks or execs in the RSP yet. > Therefore proposing the patch below. I will check it in in some time. > gdb/testsuite/ > 2011-10-09 Jan Kratochvil > > * gdb.python/py-events.exp: New comment for `set detach-on-fork off'. > (inferior 2, Inferior 2 terminated.): Run them only if not remote. > > --- a/gdb/testsuite/gdb.python/py-events.exp > +++ b/gdb/testsuite/gdb.python/py-events.exp > @@ -53,6 +53,7 @@ gdb_breakpoint "main" {temporary} > > gdb_test "run" ".*event type: new_objfile.*new objfile name.*" "New objfile notification" "run" doesn't work with "target remote" either. If that is succeeding, it's because it's actually running the default native target, which is obviously bogus. If that can't be fixed easily, we should skip the test on remote targets. But if you see failures related to fork afterwards, maybe that because you have a customboard file that runs in extended-remote? > > +# Ignored for [is_remote target]. > gdb_test_no_output "set detach-on-fork off" "" > > gdb_test "Test_Events" "Event testers registered." > @@ -75,8 +76,10 @@ gdb_test "continue" ".*event type: continue.* > .*exit code: 12.* > .*exit inf: 1.*" "Inferior 1 terminated." > > -gdb_test "inferior 2" ".*Switching to inferior 2.*" > -gdb_test "continue" ".*event type: continue.* > +if ![is_remote target] { > + gdb_test "inferior 2" ".*Switching to inferior 2.*" > + gdb_test "continue" ".*event type: continue.* > .*event type: exit.* > .*exit code: 12.* > .*exit inf: 2.*" "Inferior 2 terminated." > +} > -- Pedro Alves