From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12403 invoked by alias); 20 Oct 2011 15:59:47 -0000 Received: (qmail 12383 invoked by uid 22791); 20 Oct 2011 15:59:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 15:59:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D6E3F2BB501; Thu, 20 Oct 2011 11:59:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zobfZmCNqvHM; Thu, 20 Oct 2011 11:59:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 99AE32BB4F6; Thu, 20 Oct 2011 11:59:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1CD4E145615; Thu, 20 Oct 2011 11:59:18 -0400 (EDT) Date: Thu, 20 Oct 2011 16:21:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: John Wehle , gdb-patches@sourceware.org Subject: Re: GDB / SIM 7.3.1 Cosmetic patch for profile title Message-ID: <20111020155918.GG19246@adacore.com> References: <201110170428.p9H4SMZO025996@jwlab.FEITH.COM> <20111019004407.GD19246@adacore.com> <20111019010522.GE19246@adacore.com> <201110200017.39834.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110200017.39834.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00566.txt.bz2 > since profile_printf() takes a cpu arg, this fails to build once the > header printf is pulled out from the loop where "cpu" is declared. Ah, correct. A quick look at that function reveals that it only needs the "cpu" to get access to the associaed PROFILE_FILE. Not sure what this is and why it is necessary, rather than doing a simple printf. In any case, sounded like a good idea, but maybe it wasn't. I'll leave it to you guys if you want to pursue it. -- Joel