Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: John Wehle <john@feith.com>, gdb-patches@sourceware.org
Subject: Re: GDB / SIM 7.3.1 Cosmetic patch for profile title
Date: Thu, 20 Oct 2011 16:35:00 -0000	[thread overview]
Message-ID: <201110201220.49954.vapier@gentoo.org> (raw)
In-Reply-To: <20111020155918.GG19246@adacore.com>

[-- Attachment #1: Type: Text/Plain, Size: 1458 bytes --]

On Thursday 20 October 2011 11:59:18 Joel Brobecker wrote:
> > since profile_printf() takes a cpu arg, this fails to build once the
> > header printf is pulled out from the loop where "cpu" is declared.
> 
> Ah, correct. A quick look at that function reveals that it only needs
> the "cpu" to get access to the associaed PROFILE_FILE. Not sure what
> this is and why it is necessary, rather than doing a simple printf.
> 
> In any case, sounded like a good idea, but maybe it wasn't. I'll leave
> it to you guys if you want to pursue it.

the sim profile code has a --profile-file flag so that you can send the profile 
output to a dedicated file.  this is really useful when you're trying to pick 
apart all the other things the sim may output -- tracing, output from the 
simulated program itself, etc...  when you've got like 4+ different sources of 
information sent to one or two fd's, you can see how dedicated file flags are a 
hard necessity :).

fundamentally, the profile code operates on a per-cpu basis which makes sense 
in that the execution/profile of each cpu looks very different.  and the profile 
output code follows this convention.

atm, in practice, all output is sent to the same file handle, and most (all?) 
sims i know of only support one cpu.  so it's a bit of a wash, but i think we 
should stick to supporting the multi-cpu concept everywhere so that future 
work is much easier.

</braindump>
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2011-10-20 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17  7:13 John Wehle
2011-10-17 16:00 ` Mike Frysinger
2011-10-19  1:05 ` Joel Brobecker
2011-10-19  2:08   ` Joel Brobecker
2011-10-20  9:26     ` Mike Frysinger
2011-10-20 16:21       ` Joel Brobecker
2011-10-20 16:35         ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110201220.49954.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=john@feith.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox