From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6021 invoked by alias); 20 Oct 2011 04:17:58 -0000 Received: (qmail 6008 invoked by uid 22791); 20 Oct 2011 04:17:56 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 04:17:38 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 2EA961B4032; Thu, 20 Oct 2011 04:17:38 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: GDB / SIM 7.3.1 Cosmetic patch for profile title Date: Thu, 20 Oct 2011 09:26:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) Cc: John Wehle , gdb-patches@sourceware.org References: <201110170428.p9H4SMZO025996@jwlab.FEITH.COM> <20111019004407.GD19246@adacore.com> <20111019010522.GE19246@adacore.com> In-Reply-To: <20111019010522.GE19246@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1703646.RmqlYmDqtU"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201110200017.39834.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00550.txt.bz2 --nextPart1703646.RmqlYmDqtU Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1204 On Tuesday 18 October 2011 21:05:22 Joel Brobecker wrote: > > As a side note, it took me a while to understand some of the logic. > > It looks like `print_title_p' really means `we-have-some-profile-data'. > >=20 > > So, if it was me, [...] >=20 > In fact, here is what I meant. If someone can test it and confirm > that I didn't screw something up, we could commit that. I think > it's a lot clearer this way, no? since profile_printf() takes a cpu arg, this fails to build once the header= =20 printf is pulled out from the loop where "cpu" is declared. i think the intention might have been for the header to be printed once per= =20 cpu since the output log file exists per cpu. so if you want to pull out t= he=20 inner loop into like sim_cpu_has_profile_data (SIM_DESC sd, sim_cpu *cpu), = that=20 would probably work, but we'd still want the outer loop that walks all the= =20 cpu's in the profile_info() func. maybe we can merge that loop with the cp= u=20 loop right below ... > --- a/sim/common/sim-profile.c > +++ b/sim/common/sim-profile.c >=20 > + /* No profile data found. Return zero. */ > + return 0; > + > +} don't think you want that blank line before the closing brace -mike --nextPart1703646.RmqlYmDqtU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOn6DjAAoJEEFjO5/oN/WBddoQAMybrNGBFYIR6KGCUA29V53k gyJdC/sabv/g/J32dCHoCjDsFUt6O2xGXSwcgkdQcj74GAIP8mxoMaMQXqzxi5bT kd1L6flgUG4yJlgWjYH3zUh9VNXLagO5PVM4cJU9IKJcQYHWWVtApKziKWA+63LL xEhXUFGvie6GrgmhgGwOSA2+CQ0U3KJbBk+kA5z3NqNUVZBPNg4UZZbssaIxpKZ+ k9Dj/YGXH43H7qpSlS+WUrsgrYsC0q51jz2LEbn2QZDYrG/oNREaO6X/osL8t9g0 FDzSsuMbdCwPxn7aEs0qFcj+msf7LjPvOOg+i+0Ax7dHpkQxeEKUdEt1rJwmC3+D o8cLsflFlHuciVSOsIEundLBDy/UkXc3aBIqUGMmmeAs/6jl37ITlHrq4WXZibHE RZpDaTe49gpQbwmW4W058f4CbL/5jMlnu3o0VJROVtfsQdSIkLl3GVWfF9SBOALM dzZdCsN9JC2gwV++lr+rRkW8+uqrrob1/Ai0xIouo7NQ3cTRvzPr3rRsD62nE7Ka kSXq13ahobKnEvWErvUHAFChMbjyYlZeJz6Ue3vJ1i+bhMA2IqYBQApCdti/fvXF PSEi39Il8/rDFs0BqRC1leGXALqhuPOjgAj7QrlkJEiaHJSMGTenSG36hXT16nN+ 5G05dEB3gfRtUj51k4mY =l4K0 -----END PGP SIGNATURE----- --nextPart1703646.RmqlYmDqtU--