From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12306 invoked by alias); 19 Oct 2011 18:50:45 -0000 Received: (qmail 12294 invoked by uid 22791); 19 Oct 2011 18:50:43 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Oct 2011 18:50:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9JIoLCo019751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Oct 2011 14:50:22 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9JIoJVG006979 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Oct 2011 14:50:21 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9JIoJEU028169; Wed, 19 Oct 2011 20:50:19 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9JIoHEf028164; Wed, 19 Oct 2011 20:50:17 +0200 Date: Wed, 19 Oct 2011 20:30:00 -0000 From: Jan Kratochvil To: Chet Ramey Cc: bug-readline@gnu.org, Sterling Augustine , gdb-patches@sourceware.org Subject: Re: [Bug-readline] [readline patch, gdb-7.3?] Avoid free from a signal handler [Re: [PATCH] Make interrupting tab-completion safe.] Message-ID: <20111019185017.GA25379@host1.jankratochvil.net> References: <20110626222146.GA4410@host1.jankratochvil.net> <4E0B2E83.9030202@case.edu> <20110629203457.GA28353@host1.jankratochvil.net> <4E0C8A5D.7000807@case.edu> <20110706154621.GA17142@host1.jankratochvil.net> <110706155826.AA07325.SM@caleb.INS.CWRU.Edu> <20110706164400.GA31447@host1.jankratochvil.net> <4E15A220.4030404@case.edu> <4E17138D.9060701@case.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E17138D.9060701@case.edu> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00537.txt.bz2 On Fri, 08 Jul 2011 16:26:21 +0200, Chet Ramey wrote: > The most straightforward solution would be to move the signal setup into > rl_callback_read_char, so readline's signal handlers are in place only > when readline has control. It's still important that the application > call rl_callback_handler_remove to restore the original signal handlers. Why to keep the signal handler installed after rl_callback_read_char returns to its caller? The application (GDB) can do some rl_stuff_char(3) if it sees SIGINT and call rl_callback_read_char() then. This way all the SIGINT-hooked operations do not have to be executed from the signal handler. But you may have solved it some way as you wrote now, thanks. Regards, Jan