Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	gdb-patches@sourceware.org,        ppluzhnikov@google.com
Subject: Re: [patch 1/3] Code cleanup: strcpy + strlen -> sprintf
Date: Wed, 19 Oct 2011 14:40:00 -0000	[thread overview]
Message-ID: <20111019140817.GA4704@host1.jankratochvil.net> (raw)
In-Reply-To: <m3lish2ief.fsf@fleche.redhat.com>

On Wed, 19 Oct 2011 15:57:44 +0200, Tom Tromey wrote:
> Jan> I am unfamiliar with gdbserver but there is no single use of snprintf while
> Jan> 75 uses of sprintf.  Isn't it for some platform compatibility?
> 
> The gnulib page is informative:
> 
> http://www.gnu.org/s/hello/manual/gnulib/snprintf.html

thanks, this and
	http://www.gnu.org/s/hello/manual/gnulib/sprintf.html
would suggest sprintf wrt OS compatibility is OK but snprintf is not and
therefore this [patch 1/3] is the best + compatible variant.

Still I no longer mind much, I am going to drop this 3-part series (unless
discussed otherwise) and return back to the former form with incompatible/new
SVR4 protocol and separate protocol producer/consumer:
	Re: [patch 3/3] Implement qXfer:libraries for Linux/gdbserver #2
	http://sourceware.org/ml/gdb-patches/2011-10/msg00175.html

This variant has no technical advantages, the code is just more tricky.


Thanks,
Jan


      reply	other threads:[~2011-10-19 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18 20:52 Jan Kratochvil
2011-10-19  0:24 ` Mark Kettenis
2011-10-19  8:40   ` Jan Kratochvil
2011-10-19 14:08     ` Tom Tromey
2011-10-19 14:40       ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111019140817.GA4704@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=ppluzhnikov@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox