From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3179 invoked by alias); 17 Oct 2011 17:06:49 -0000 Received: (qmail 3169 invoked by uid 22791); 17 Oct 2011 17:06:49 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 17:06:35 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id CF14A1B403C; Mon, 17 Oct 2011 17:06:34 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH] sim: dv-cfi: include stdbool.h Date: Mon, 17 Oct 2011 17:08:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1310410693-20883-1-git-send-email-vapier@gentoo.org> <20111017165024.GB17942@adacore.com> In-Reply-To: <20111017165024.GB17942@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110171306.34450.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00476.txt.bz2 On Monday 17 October 2011 12:50:24 Joel Brobecker wrote: > > The dv-cfi code uses the bool type but doesn't include the stdbool.h > > header. I didn't notice for Blackfin targets as the core Blackfin > > header will include stdbool.h, but most targets don't do this. > > > > Signed-off-by: Mike Frysinger > > > > 2011-07-11 Mike Frysinger > > > > * dv-cfi.c: Include stdbool.h. > > I don't think that this is right. stdbool.h is C99, whereas GDB should > build with a C90 compiler. hmm, i was not aware of this. i thought it dated back further. > What we should do is get rid of uses of true and false, and use the > typical zero/nonzero values instead. I think that the blackfin header > and code should be cleaned up accordingly as well. ah, this would make me sad. would a configure check for stdbool.h be acceptable ? -mike