Re: GDB / SIM 7.3.1 Cosmetic patch for profile title

Mike Frysinger
2011-10-20T04:17:58Z

[-- Attachment #1: Type: Text/Plain, Size: 1204 bytes --]

On Tuesday 18 October 2011 21:05:22 Joel Brobecker wrote:
> > As a side note, it took me a while to understand some of the logic.
> > It looks like `print_title_p' really means `we-have-some-profile-data'.
> >
> > So, if it was me, [...]
>
> In fact, here is what I meant. If someone can test it and confirm
> that I didn't screw something up, we could commit that. I think
> it's a lot clearer this way, no?

since profile_printf() takes a cpu arg, this fails to build once the header
printf is pulled out from the loop where "cpu" is declared.

i think the intention might have been for the header to be printed once per
cpu since the output log file exists per cpu. so if you want to pull out the
inner loop into like sim_cpu_has_profile_data (SIM_DESC sd, sim_cpu *cpu), that
would probably work, but we'd still want the outer loop that walks all the
cpu's in the profile_info() func. maybe we can merge that loop with the cpu
loop right below ...

> --- a/sim/common/sim-profile.c
> +++ b/sim/common/sim-profile.c
>
> + /* No profile data found. Return zero. */
> + return 0;
> +
> +}

don't think you want that blank line before the closing brace
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]