From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18209 invoked by alias); 13 Oct 2011 15:19:44 -0000 Received: (qmail 18199 invoked by uid 22791); 13 Oct 2011 15:19:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 15:19:26 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=EU1-MAIL.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1REN49-000068-PC from pedro_alves@mentor.com ; Thu, 13 Oct 2011 08:19:25 -0700 Received: from scottsdale.localnet ([172.16.63.104]) by EU1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 13 Oct 2011 16:19:23 +0100 From: Pedro Alves To: Kevin Pouget Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug Date: Thu, 13 Oct 2011 15:19:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.7.1; x86_64; ; ) Cc: Tom Tromey , pmuldoon@redhat.com, gdb-patches@sourceware.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201110131619.22442.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00398.txt.bz2 The patch appears to be missing unwind_stop_reasons.def. > +#define SET(name, description) \ > + PyModule_AddIntConstant (gdb_module, "FRAME_"#name, unwind_cpt++); > +#include "gdb/unwind_stop_reasons.def" What's that `unwind_cpt' for? Wouldn't: #define SET(name, description) \ PyModule_AddIntConstant (gdb_module, "FRAME_"#name, name); work? -- Pedro Alves