Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix internal error on optimized-out values (regression by me)
Date: Wed, 12 Oct 2011 20:11:00 -0000	[thread overview]
Message-ID: <20111012201130.GA21491@host1.jankratochvil.net> (raw)
In-Reply-To: <m38vora2bu.fsf@fleche.redhat.com>

On Tue, 11 Oct 2011 19:02:45 +0200, Tom Tromey wrote:
> Given this I tend to think that the patch that went in is incorrect,

Which patch do you refer to here?  Neither of the two proposed patch of mine
in this threads went it yet.


> in
> that it may break operations on an SRA'd structure where some bits are
> optimized away.  I thought I added tests for this, not sure though.

Missing DW_AT_data_member_location is defined as offset 0.  Not sure how an
optimized out field should look like.  Empty DWARF block will just not modify
the struct base address, therefore it may mean also the offset 0 instead of
optimized-out value.  And popping the base address keeping the stack empty is
not an empty DWARF block then.

I tried some testcase but I failed to force GCC making a field optimized out.


Thanks,
Jan


  reply	other threads:[~2011-10-12 20:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 19:26 Jan Kratochvil
2011-09-27 13:41 ` Jan Kratochvil
2011-10-03 19:34   ` Tom Tromey
2011-10-10 20:54     ` Jan Kratochvil
2011-10-10 21:40       ` Pedro Alves
2011-10-11 17:33         ` Tom Tromey
2011-10-12 20:11           ` Jan Kratochvil [this message]
2011-10-13 15:18             ` Tom Tromey
2011-10-13 16:36               ` Jan Kratochvil
2011-10-12 20:33         ` Jan Kratochvil
2011-10-13 15:27           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012201130.GA21491@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox