Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: [obv] Fix gdb.cp/namespace-enum.exp compilation  [Re: Make DW_TAG_enumerator's consistent, regardless of containing scope]
Date: Wed, 12 Oct 2011 09:21:00 -0000	[thread overview]
Message-ID: <20111012092043.GA27923@host1.jankratochvil.net> (raw)
In-Reply-To: <CAEG7qUxxHU2hXKCeNiSMceQfNSQhRdtzxxi+D6DV_hpf3w3GWA@mail.gmail.com>

On Tue, 11 Oct 2011 20:27:33 +0200, Sterling Augustine wrote:
> gdb/ChangeLog
> 2011-10-07  Sterling Augustine  <saugustine@google.com>
> 
>        * dwarf2read.c (partial_die_parent_scope): Rearrange conditional
>        logic.
> 
> gdb/testsuite/gdb.cp/ChangeLog
> 2011-10-10  Sterling Augustine  <saugustine@google.com>
> 
>        * gdb.cp/Makefile.in: Add namespace-enum test.
>        * gdb.cp/namespace-enum.exp: New file.
>        * gdb.cp/namespace-enum.c: New file.
>        * gdb.cp/namespace-enum-main.c: New file.

+Running gdb/testsuite/gdb.cp/namespace-enum.exp ...
+ERROR: (gdb/testsuite.unix.-m32/gdb.cp/namespace-enum) No such file or directory
+UNRESOLVED: gdb.cp/namespace-enum.exp: print foo::B::B_B
+FAIL: gdb.cp/namespace-enum.exp: print foo::B_B
+FAIL: gdb.cp/namespace-enum.exp: print A_A

There is a bit problem in the current testsuite framework some functions expect
the subdirectory prefix and some do not.

Checked in.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-10/msg00098.html

--- src/gdb/testsuite/ChangeLog	2011/10/11 19:19:08	1.2893
+++ src/gdb/testsuite/ChangeLog	2011/10/12 09:19:41	1.2894
@@ -1,3 +1,9 @@
+2011-10-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.cp/namespace-enum.exp (executable): New variable.
+	(binfile): Use ${objdir}/${subdir}/ prefix.
+	Use ${executable} for clean_restart.
+
 2011-10-11  Sterling Augustine  <saugustine@google.com>
 
 	* gdb.cp/Makefile.in: Add namespace-enum test.
--- src/gdb/testsuite/gdb.cp/namespace-enum.exp	2011/10/11 19:19:08	1.1
+++ src/gdb/testsuite/gdb.cp/namespace-enum.exp	2011/10/12 09:19:42	1.2
@@ -18,7 +18,8 @@
 set objfile0 ${testfile}.o
 set srcfile1 ${testfile}-main.cc
 set objfile1 ${testfile}-main.o
-set binfile ${testfile}
+set executable ${testfile}
+set binfile ${objdir}/${subdir}/${executable}
 
 if  { [gdb_compile "$srcdir/$subdir/$srcfile0" "$objdir/$subdir/$objfile0" object {debug c++}] != "" } {
      untested namespace-enum.exp
@@ -35,7 +36,7 @@
      return -1
 }
 
-clean_restart ${binfile}
+clean_restart ${executable}
 gdb_test "print foo::B::B_B" "`foo::B' is not defined as an aggregate type."
 gdb_test "print foo::B_B" "foo::B_B"
 gdb_test "print A_A" "A_A"


      parent reply	other threads:[~2011-10-12  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 21:27 Make DW_TAG_enumerator's consistent, regardless of containing scope Sterling Augustine
2011-10-07 23:43 ` Keith Seitz
2011-10-08  0:46   ` Sterling Augustine
2011-10-10 22:21 ` Sterling Augustine
2011-10-11 17:07   ` Tom Tromey
2011-10-11 18:27     ` Sterling Augustine
2011-10-11 19:04       ` Tom Tromey
2011-10-12  9:21       ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012092043.GA27923@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=saugustine@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox