From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] Fix regcache_restore() handling of unavailable regs.
Date: Tue, 11 Oct 2011 10:45:00 -0000 [thread overview]
Message-ID: <201110111144.49959.pedro@codesourcery.com> (raw)
In-Reply-To: <20111011.024027.2269565520682513251.davem@davemloft.net>
On Tuesday 11 October 2011 07:40:27, David Miller wrote:
>
> Across inferior dummy calls, regcache entries which were "unavailable"
> were restored incorrectly after such dummy calls. The problem is
> incorrect interpretation of cooked_read()'s return value in
> regcache_restore().
>
> Ok to commit?
Okay.
I don't think the problem is fully solved though. If it happens
that the same set of registers are unavailable in src/dst,
then things work. If if not, nothing is marking the dst
register as unavailable. And that's tricky, due to pseudo
registers, and partially available registers. I think this will
need a bit more surgery to fix properly. Until then, please
apply your patch. I'll add a TODO to think about this.
OOC, what register are you seeing as unavailable? Is this a
case of ptrace not exposing all the machine's registers?
A context where the kernel hasn't saved all registers (a signal
frame, or something like that). Something else?
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2011-10-11 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 6:40 David Miller
2011-10-11 10:45 ` Pedro Alves [this message]
2011-10-11 18:28 ` David Miller
2011-10-11 10:50 ` Pedro Alves
2011-10-11 18:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110111144.49959.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox